Add consts to dump methods

Change-Id: I5fcbfd24cede40c6baa04bb42533c2994de4fe27
Reviewed-on: http://review.couchbase.org/110274
Tested-by: Build Bot <[email protected]>
Reviewed-by: Dave Rigby <[email protected]>

Author: trondn

include/mcbp/mcbp.h

@@ -55,8 +55,7 @@ void dump(const Header& header, std::ostream& out);
  * @param buffer the buffer containing the data
  * @param out Where to dump the data
  */
-void dumpStream(cb::byte_buffer buffer, std::ostream& out);
-
+void dumpStream(cb::const_byte_buffer buffer, std::ostream& out);
 
 /**
  * Print a byte dump of a buffer in the following format:
@@ -69,8 +68,9 @@ void dumpStream(cb::byte_buffer buffer, std::ostream& out);
  *               specified in the buffer, and this is may be used if the
  *               buffer to display is a small segment of a larger blob)
  */
-void dumpBytes(cb::byte_buffer buffer, std::ostream& out, size_t offset = 0);
-
+void dumpBytes(cb::const_byte_buffer buffer,
+               std::ostream& out,
+               size_t offset = 0);
 
 namespace gdb {
 /**
@@ -81,7 +81,7 @@ namespace gdb {
  * 0x7f43387d7e82: 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
  * 0x7f43387d7e8a: 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
  */
-std::vector<uint8_t> parseDump(cb::byte_buffer blob);
+std::vector<uint8_t> parseDump(cb::const_byte_buffer blob);
 } // namespace gdb
 
 namespace lldb {
@@ -92,7 +92,7 @@ namespace lldb {
  * 0xaddr: 81 0d 00 01 04 00 00 00 00 00 00 06 00 00 00 06  ................
  * 0xaddr: 14 bf f4 26 8a e0 00 00 00 00 00 00 61 61 81 0a  .��&.�......aa..
  */
-std::vector<uint8_t> parseDump(cb::byte_buffer blob);
+std::vector<uint8_t> parseDump(cb::const_byte_buffer blob);
 }
 
 namespace sla {

protocol/mcbp/dump.cc

@@ -34,7 +34,7 @@
 namespace cb {
 namespace mcbp {
 
-void dumpBytes(cb::byte_buffer buffer, std::ostream& out, size_t offset) {
+void dumpBytes(cb::const_byte_buffer buffer, std::ostream& out, size_t offset) {
     out << std::hex;
     size_t nbytes = 0;
     while (nbytes < buffer.size()) {
@@ -578,7 +578,7 @@ void cb::mcbp::dump(const uint8_t* packet, std::ostream& out) {
     dump(*reinterpret_cast<const cb::mcbp::Header*>(packet), out);
 }
 
-void cb::mcbp::dumpStream(cb::byte_buffer buffer, std::ostream& out) {
+void cb::mcbp::dumpStream(cb::const_byte_buffer buffer, std::ostream& out) {
     size_t offset = 0;
 
     while ((offset + sizeof(Header)) <= buffer.len) {

protocol/mcbp/gdb_dump_parser.cc

@@ -26,7 +26,7 @@ namespace cb {
 namespace mcbp {
 namespace gdb {
 
-std::vector<uint8_t> parseDump(cb::byte_buffer blob) {
+std::vector<uint8_t> parseDump(cb::const_byte_buffer blob) {
     std::vector<uint8_t> ret;
 
     const uint8_t* end = blob.data() + blob.size();

protocol/mcbp/lldb_dump_parser.cc

@@ -26,7 +26,7 @@ namespace cb {
 namespace mcbp {
 namespace lldb {
 
-std::vector<uint8_t> parseDump(cb::byte_buffer blob) {
+std::vector<uint8_t> parseDump(cb::const_byte_buffer blob) {
     std::vector<uint8_t> ret;
 
     const uint8_t* end = blob.data() + blob.size();