MB-27554: [BP] Make VBucket::getNumNonResidentItems virtual

Originally a647ff3

Change VBucket::getNumNonResidentItems() to be a virtual method, with
implementations for Ephemeral and EP VBuckets.

Change-Id: Ic73bd50c77e38f89a38cc52c794415f6bb428fff
Reviewed-on: http://review.couchbase.org/88378
Well-Formed: Build Bot <[email protected]>
Tested-by: Build Bot <[email protected]>
Reviewed-by: Dave Rigby <[email protected]>

Author: daverigby

engines/ep/src/ep_vb.cc

@@ -261,6 +261,17 @@ size_t EPVBucket::getNumItems() const {
     }
 }
 
+size_t EPVBucket::getNumNonResidentItems() const {
+    if (eviction == VALUE_ONLY) {
+        return ht.getNumInMemoryNonResItems();
+    } else {
+        size_t num_items = ht.getNumItems();
+        size_t num_res_items =
+                ht.getNumInMemoryItems() - ht.getNumInMemoryNonResItems();
+        return num_items > num_res_items ? (num_items - num_res_items) : 0;
+    }
+}
+
 ENGINE_ERROR_CODE EPVBucket::statsVKey(const DocKey& key,
                                        const void* cookie,
                                        EventuallyPersistentEngine& engine,

engines/ep/src/ep_vb.h

@@ -71,6 +71,8 @@ class EPVBucket : public VBucket {
 
     size_t getNumItems() const override;
 
+    size_t getNumNonResidentItems() const override;
+
     ENGINE_ERROR_CODE statsVKey(const DocKey& key,
                                 const void* cookie,
                                 EventuallyPersistentEngine& engine,

engines/ep/src/ephemeral_vb.h

@@ -72,6 +72,10 @@ class EphemeralVBucket : public VBucket {
 
     size_t getNumItems() const override;
 
+    size_t getNumNonResidentItems() const override {
+        return 0;
+    }
+
     ENGINE_ERROR_CODE statsVKey(const DocKey& key,
                                 const void* cookie,
                                 EventuallyPersistentEngine& engine,

engines/ep/src/vbucket.h

@@ -556,7 +556,7 @@ class VBucket : public std::enable_shared_from_this<VBucket> {
      */
     virtual size_t getNumItems() const = 0;
 
-    size_t getNumNonResidentItems() const;
+    virtual size_t getNumNonResidentItems() const = 0;
 
     size_t getNumTempItems(void) {
         return ht.getNumTempItems();