Skip to content

Commit 494f768

Browse files
trondndaverigby
authored andcommitted
[cbsasl] move saslprep test to the source
And link it into the same binary which tests the string comparison function in cbsasl to reduce the link time and runtime cost of two separate binaries which just a handful of tests Change-Id: Iad87aa960c3cd631a4fddc5d5eca9024694f0362 Reviewed-on: http://review.couchbase.org/c/kv_engine/+/135599 Tested-by: Trond Norbye <[email protected]> Reviewed-by: Dave Rigby <[email protected]>
1 parent 822c89d commit 494f768

File tree

4 files changed

+5
-16
lines changed

4 files changed

+5
-16
lines changed

cbsasl/CMakeLists.txt

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,12 @@ install(TARGETS cbsasl
4343

4444
# Unit tests
4545
if (COUCHBASE_KV_BUILD_UNIT_TESTS)
46-
add_executable(cbsasl_strcmp_test strcmp_test.cc
47-
strcmp.cc
48-
util.h)
49-
target_link_libraries(cbsasl_strcmp_test gtest gtest_main)
50-
add_test(NAME cbsasl-strcmp
46+
add_executable(cbsasl_utils_test strcmp_test.cc
47+
scram-sha/saslprep_test.cc)
48+
target_link_libraries(cbsasl_utils_test cbsasl gtest gtest_main)
49+
add_test(NAME cbsasl_utils_test
5150
WORKING_DIRECTORY ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}
52-
COMMAND cbsasl_strcmp_test)
51+
COMMAND cbsasl_utils_test)
5352

5453
add_executable(cbsasl_pwconv_test
5554
${Memcached_SOURCE_DIR}/include/cbcrypto/cbcrypto.h
File renamed without changes.

tests/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ ADD_SUBDIRECTORY(histograms)
1212
ADD_SUBDIRECTORY(mc_time)
1313
ADD_SUBDIRECTORY(mcbp)
1414
ADD_SUBDIRECTORY(memory_tracking_test)
15-
ADD_SUBDIRECTORY(saslprep)
1615
ADD_SUBDIRECTORY(scripts_tests)
1716
ADD_SUBDIRECTORY(sizes)
1817
ADD_SUBDIRECTORY(testapp)

tests/saslprep/CMakeLists.txt

Lines changed: 0 additions & 9 deletions
This file was deleted.

0 commit comments

Comments
 (0)