MB-58665: [testapp] full-eviction returns tmpfail for unlock

trondn · trondn · commit 4f3034ff09b5 · 2023-09-15T10:16:37.000Z
if the document doesn't exists Change-Id: Ibff0554dff150d8e1cb3bd91d2f6062fe7e3f3c7 Reviewed-on: https://review.couchbase.org/c/kv_engine/+/197174 Reviewed-by: Paolo Cocchi <paolo.cocchi@couchbase.com> Tested-by: Build Bot <build@couchbase.com>
diff --git a/tests/testapp/testapp_lock.cc b/tests/testapp/testapp_lock.cc
@@ -148,11 +148,14 @@ TEST_P(LockTest, DeleteLockedDocument) {
 
 TEST_P(LockTest, UnlockNoSuchDocument) {
     try {
+        userConnection->setAutoRetryTmpfail(false);
         userConnection->unlock(name, Vbid(0), 0xdeadbeef);
         FAIL() << "The document should not exist";
     } catch (const ConnectionError& ex) {
-        EXPECT_TRUE(ex.isNotFound());
+        // full eviction returns tmpfail
+        EXPECT_TRUE(ex.isNotFound() || ex.isTemporaryFailure());
     }
+    userConnection->setAutoRetryTmpfail(true);
 }
 
 TEST_P(LockTest, UnlockInvalidVBucket) {

Original file line number	Diff line number	Diff line change
`@@ -148,11 +148,14 @@ TEST_P(LockTest, DeleteLockedDocument) {`
`148`	`148`
`149`	`149`	`TEST_P(LockTest, UnlockNoSuchDocument) {`
`150`	`150`	`try {`
	`151`	`+ userConnection->setAutoRetryTmpfail(false);`
`151`	`152`	`userConnection->unlock(name, Vbid(0), 0xdeadbeef);`
`152`	`153`	`FAIL() << "The document should not exist";`
`153`	`154`	`} catch (const ConnectionError& ex) {`
`154`		`- EXPECT_TRUE(ex.isNotFound());`
	`155`	`+ // full eviction returns tmpfail`
	`156`	`+ EXPECT_TRUE(ex.isNotFound() \|\| ex.isTemporaryFailure());`
`155`	`157`	`}`
	`158`	`+ userConnection->setAutoRetryTmpfail(true);`
`156`	`159`	`}`
`157`	`160`
`158`	`161`	`TEST_P(LockTest, UnlockInvalidVBucket) {`