MB-45408: Enabled some PiTR test variants

This requires that we don't assert that the dropped collections
list is empty after we compact if we have PiTR enabled.

Change-Id: I6377ae0e0f74be73d111e58bdc381d010a5d7960
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/171937
Tested-by: Build Bot <[email protected]>
Reviewed-by: Dave Rigby <[email protected]>

Author: BenHuddleston

engines/ep/tests/module_tests/collections/evp_store_collections_test.cc

@@ -4558,6 +4558,11 @@ INSTANTIATE_TEST_SUITE_P(CollectionsEphemeralOrPersistent,
                          STParameterizedBucketTest::allConfigValues(),
                          STParameterizedBucketTest::PrintToStringParamName);
 
+INSTANTIATE_TEST_SUITE_P(CollectionsEphemeralOrPersistentPitrEnabled,
+                         CollectionsParameterizedTest,
+                         STParameterizedBucketTest::pitrEnabledConfigValues(),
+                         STParameterizedBucketTest::PrintToStringParamName);
+
 INSTANTIATE_TEST_SUITE_P(CollectionsEphemeralOnlyTests,
                          CollectionsEphemeralParameterizedTest,
                          STParameterizedBucketTest::ephConfigValues(),

engines/ep/tests/module_tests/evp_store_durability_test.cc

@@ -5071,6 +5071,11 @@ INSTANTIATE_TEST_SUITE_P(AllBackends,
                          STParameterizedBucketTest::allConfigValues(),
                          STParameterizedBucketTest::PrintToStringParamName);
 
+INSTANTIATE_TEST_SUITE_P(AllBackendsPitrEnabled,
+                         DurabilityBucketTest,
+                         STParameterizedBucketTest::pitrEnabledConfigValues(),
+                         STParameterizedBucketTest::PrintToStringParamName);
+
 // maxVisibleSeqno tests run against all persistent storage backends.
 INSTANTIATE_TEST_SUITE_P(AllBackends,
                          BackingStoreMaxVisibleSeqnoTest,

engines/ep/tests/module_tests/evp_store_single_threaded_test.cc

@@ -469,7 +469,16 @@ void SingleThreadedKVBucketTest::scheduleAndRunCollectionsEraser(
                                              ->getRWUnderlying()
                                              ->getDroppedCollections(id);
             ASSERT_TRUE(status);
-            EXPECT_TRUE(dropped.empty());
+            if (!isPitrEnabled()) {
+                // We are trying to check if the dropped collections are
+                // still present on disk. The document is typically deleted
+                // during compaction but with PiTR we have some extra
+                // criteria to hit that we don't in this test (the compacting
+                // headers must be older than the max history age). As such,
+                // the dropped collections (and the data that belongs to them)
+                // are still present on disk for PiTR tests.
+                EXPECT_TRUE(dropped.empty());
+            }
         }
     } else {
         auto* bucket = dynamic_cast<EphemeralBucket*>(store);