MB-37781: Remove no-manifest error

This error code is no longer used - remove.

Change-Id: I9dc425874416f35604f211157bdfbd3245bc10f1
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/137669
Tested-by: Build Bot <[email protected]>
Reviewed-by: Richard de Mellow <[email protected]>

Author: jimwwalker

daemon/protocol/mcbp/executors.cc

@@ -57,7 +57,6 @@ void handle_executor_status(Cookie& cookie, cb::engine_errc status) {
     case engine_errc::locked_tmpfail:
     case engine_errc::unknown_collection:
     case engine_errc::predicate_failed:
-    case engine_errc::no_collections_manifest:
     case engine_errc::cannot_apply_collections_manifest:
     case engine_errc::collections_manifest_is_ahead:
     case engine_errc::unknown_scope:

engines/utilities/engine_error.cc

@@ -94,8 +94,6 @@ std::string cb::to_string(cb::engine_errc code) {
         return "unknown collection";
     case cb::engine_errc::predicate_failed:
         return "predicate_failed";
-    case cb::engine_errc::no_collections_manifest:
-        return "no_collections_manifest";
     case cb::engine_errc::cannot_apply_collections_manifest:
         return "cannot_apply_collections_manifest";
     case cb::engine_errc::collections_manifest_is_ahead:

include/mcbp/protocol/status.h

@@ -112,11 +112,6 @@ enum class Status : uint16_t {
      */
     UnknownCollection = 0x88,
 
-    /**
-     * Operation attempted and requires that the collections manifest is set.
-     */
-    NoCollectionsManifest = 0x89,
-
     /**
      * Bucket Manifest update could not be applied to vbucket(s)
      */

include/memcached/engine_error.h

@@ -99,11 +99,6 @@ enum class engine_errc {
      */
     predicate_failed = 0x17,
 
-    /**
-     * The request cannot complete until a collections manifest has been set
-     */
-    no_collections_manifest = 0x18,
-
     /**
      * The collections manifest passed validation but could not be applied
      */

protocol/mcbp/status.cc

@@ -53,7 +53,6 @@ bool isStatusSuccess(Status status) {
     case Status::Etmpfail:
     case Status::XattrEinval:
     case Status::UnknownCollection:
-    case Status::NoCollectionsManifest:
     case Status::CannotApplyCollectionsManifest:
     case Status::CollectionsManifestIsAhead:
     case Status::UnknownScope:
@@ -172,8 +171,6 @@ std::string to_string(cb::mcbp::Status status) {
         return "Invalid XATTR section";
     case Status::UnknownCollection:
         return "Unknown Collection";
-    case Status::NoCollectionsManifest:
-        return "No Collections Manifest";
     case Status::CannotApplyCollectionsManifest:
         return "Cannot apply collections manifest";
     case Status::CollectionsManifestIsAhead:

utilities/engine_errc_2_mcbp.cc

@@ -60,8 +60,6 @@ cb::mcbp::Status cb::mcbp::to_status(cb::engine_errc code) {
         return Status::Locked;
     case engine_errc::unknown_collection:
         return Status::UnknownCollection;
-    case engine_errc::no_collections_manifest:
-        return Status::NoCollectionsManifest;
     case engine_errc::cannot_apply_collections_manifest:
         return Status::CannotApplyCollectionsManifest;
     case engine_errc::collections_manifest_is_ahead: