MB-51413: Create MockCouchKVStore in replaceCouchKVStore

It's test code so the greater flexibility is useful.

Change-Id: Ib76d1c35b85db9d9e725b2fde6bbd11f42824ae1
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/172221
Tested-by: Ben Huddleston <[email protected]>
Reviewed-by: Dave Rigby <[email protected]>

Author: BenHuddleston

engines/ep/tests/mock/mock_couch_kvstore.h

@@ -66,6 +66,10 @@ class MockCouchKVStore : public CouchKVStore {
         : CouchKVStore(config) {
     }
 
+    MockCouchKVStore(const CouchKVStoreConfig& config, FileOpsInterface& ops)
+        : CouchKVStore(config, ops) {
+    }
+
     /// Read-Only constructor where we are given a RevisionMap
     MockCouchKVStore(const CouchKVStoreConfig& config,
                      std::shared_ptr<RevisionMap> dbFileRevMap)

engines/ep/tests/module_tests/kv_bucket_test.cc

@@ -41,6 +41,7 @@
 #include "lambda_task.h"
 #include "replicationthrottle.h"
 #include "tasks.h"
+#include "tests/mock/mock_couch_kvstore.h"
 #include "tests/mock/mock_global_task.h"
 #include "tests/mock/mock_synchronous_ep_engine.h"
 #include "tests/module_tests/test_helpers.h"
@@ -494,7 +495,7 @@ void KVBucketTest::replaceCouchKVStore(FileOpsInterface& ops) {
     ASSERT_EQ(engine->getConfiguration().getBackend(), "couchdb");
 
     const auto& config = store->getRWUnderlying(vbid)->getConfig();
-    auto rw = std::make_unique<CouchKVStore>(
+    auto rw = std::make_unique<MockCouchKVStore>(
             dynamic_cast<const CouchKVStoreConfig&>(config), ops);
 
     const auto shardId = store->getShardId(vbid);

engines/ep/tests/module_tests/kv_bucket_test.h

@@ -314,8 +314,9 @@ class KVBucketTest : virtual public ::testing::Test {
     Collections::Manager& getCollectionsManager();
 
     /**
-     * Replace the r/w KVStore with one that uses the given ops. This function
-     * will test the config to be sure the KVBucket is persistent/couchstore.
+     * Replace the r/w KVStore with a MockCouchKVStore that uses the given ops.
+     * This function will test the config to be sure the KVBucket is
+     * persistent/couchstore.
      */
     void replaceCouchKVStore(FileOpsInterface& ops);