MB-43076: [BP] Make -P optional in kv_trace_dump

That allows kv_trace_dump to use the CB_PASSWORD env var in the
invocation to mcctl.

Change-Id: Iea3eda21f183574b84106c86e73ff0413e3b1b79
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/141852
Well-Formed: Build Bot <[email protected]>
Reviewed-by: Dave Rigby <[email protected]>
Tested-by: Paolo Cocchi <[email protected]>

Author: paolococchi

engines/ep/management/kv_trace_dump

@@ -31,7 +31,7 @@ parser.add_argument('--mcctl', help='Path to mcctl binary')
 parser.add_argument('-H', '--hostname', required=True,
                     help='host:port to connect to (e.g. localhost:11210)')
 parser.add_argument('-u', '--username', required=True, help='Username')
-parser.add_argument('-P', '--password', required=True, help='Password')
+parser.add_argument('-P', '--password', required=False, help='Password')
 parser.add_argument('-n', '--norestart', dest='restart', action='store_false',
                     help="Don't restart tracing after dumping the trace file")
 parser.add_argument('outfile', type=argparse.FileType('w'))
@@ -67,8 +67,10 @@ if not os.path.isfile(mcctl_bin):
 
 mcctl_args = [mcctl_bin,
               '-h', args.hostname,
-              '-u', args.username,
-              '-P', args.password]
+              '-u', args.username]
+
+if args.password:
+    mcctl_args.extend(['-P', args.password])
 
 subprocess.check_call(mcctl_args + ['set', 'trace.stop'])
 uuid = subprocess.check_output(mcctl_args + ['get', 'trace.dump.begin'],