Skip to content

Commit 712454c

Browse files
committed
MB-52958: Remove Magma::Config::IsValueCompressed
This is now unused - as per Rohan Suri: "It is unused. i added it initially to do lz4 compression for large values on Magma side if KV hasn't already compressed it. but later we decided to just skip compression altogether for large values (in this patch: https://review.couchbase.org/c/magma/+/180232)" Remove setting it in KV-Engine, in preparation for removing the member entirely from Magma. Change-Id: I1153c8a6060490f3e5566b702612325c6483892f Reviewed-on: https://review.couchbase.org/c/kv_engine/+/189915 Tested-by: Build Bot <[email protected]> Reviewed-by: Paolo Cocchi <[email protected]>
1 parent b441561 commit 712454c

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

engines/ep/src/kvstore/magma-kvstore/magma-kvstore.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,6 @@ MagmaKVStore::MagmaKVStore(MagmaKVStoreConfig& configuration)
598598
configuration.magmaCfg.KVStorePurgerInterval =
599599
configuration.getMagmaExpiryPurgerInterval();
600600
configuration.magmaCfg.GetSeqNum = magmakv::getSeqNum;
601-
configuration.magmaCfg.IsValueCompressed = magmakv::isCompressed;
602601
configuration.magmaCfg.GetExpiryTime = [this](const magma::Slice& slice) {
603602
return getExpiryOrPurgeTime(slice);
604603
};

0 commit comments

Comments
 (0)