MB-35589: Extend select bucket logging

Add log entries when select bucket fails due to EACCESS:

INFO 61: select_bucket failed - Not authenticated.

Followed by JSON with more information:

    {
       "cid": "127.0.0.1:39668/efbeadde",
       "connection": "[ 127.0.0.1:39668 - 127.0.0.1:37011 (not authenticated) ]",
       "bucket": "foo"
    }

Change-Id: I904298e411dafa7dfb70e41f8b21dd40f3a34693
Reviewed-on: http://review.couchbase.org/113628
Reviewed-by: Matt Ingenthron <[email protected]>
Reviewed-by: Dave Rigby <[email protected]>
Tested-by: Trond Norbye <[email protected]>

Author: trondn

daemon/protocol/mcbp/select_bucket_executor.cc

@@ -27,17 +27,28 @@
 ENGINE_ERROR_CODE select_bucket(Cookie& cookie, const std::string& bucketname) {
     auto& connection = cookie.getConnection();
     if (!connection.isAuthenticated()) {
+        cookie.setErrorContext("Not authenticated");
+        LOG_INFO(
+                "{}: select_bucket failed - Not authenticated. "
+                R"({{"cid":"{}/{:x}","connection":"{}","bucket":"{}"}})",
+                connection.getId(),
+                connection.getConnectionId().data(),
+                ntohl(cookie.getRequest().getOpaque()),
+                connection.getDescription(),
+                bucketname);
         return ENGINE_EACCESS;
     }
 
     // We can't switch bucket if we've got multiple commands in flight
     if (connection.getNumberOfCookies() > 1) {
         LOG_INFO(
-                "{}: {} select_bucket [{}] is not possible with multiple "
-                "commands in flight",
+                "{}: select_bucket failed - multiple commands in flight. "
+                R"({{"cid":"{}/{:x}","connection":"{}","bucket":"{}"}})",
                 connection.getId(),
-                bucketname,
-                connection.getDescription());
+                connection.getConnectionId().data(),
+                ntohl(cookie.getRequest().getOpaque()),
+                connection.getDescription(),
+                bucketname);
         return ENGINE_ENOTSUP;
     }
 
@@ -72,6 +83,14 @@ ENGINE_ERROR_CODE select_bucket(Cookie& cookie, const std::string& bucketname) {
             return ENGINE_KEY_ENOENT;
         }
     } catch (const cb::rbac::Exception&) {
+        LOG_INFO(
+                "{}: select_bucket failed - No access. "
+                R"({{"cid":"{}/{:x}","connection":"{}","bucket":"{}"}})",
+                connection.getId(),
+                connection.getConnectionId().data(),
+                ntohl(cookie.getRequest().getOpaque()),
+                connection.getDescription(),
+                bucketname);
         return ENGINE_EACCESS;
     }
 }