MB-49040: 5/n Update scope data-size during warmup

As we load the collection data size from disk call through
to also update the scope data size.

Change-Id: Ibc2892ec2a1450befb7cada37573b457b0aaeff4
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/164367
Tested-by: Build Bot <[email protected]>
Reviewed-by: Paolo Cocchi <[email protected]>

Author: jimwwalker

engines/ep/src/warmup.cc

@@ -1477,6 +1477,9 @@ void Warmup::loadCollectionStatsForShard(uint16_t shardId) {
             // Set the in memory high seqno - might be 0 in the case of the
             // default collection so we have to reset the monotonic value
             collection.second.resetHighSeqno(stats.highSeqno);
+
+            // And update the scope data size
+            wh.updateDataSize(collection.second.getScopeID(), stats.diskSize);
         }
     }
 

engines/ep/tests/module_tests/collections/evp_store_collections_test.cc

@@ -1027,6 +1027,7 @@ TEST_F(CollectionsWarmupTest, warmup) {
     CollectionsManifest cm;
     uint32_t uid = 0xface2;
     cm.setUid(uid);
+    size_t scopeDataSize = 0;
     {
         auto vb = store->getVBucket(vbid);
 
@@ -1067,6 +1068,8 @@ TEST_F(CollectionsWarmupTest, warmup) {
         EXPECT_EQ(3,
                   store->getVBucket(vbid)->lockCollections().getHighSeqno(
                           CollectionEntry::fruit));
+        scopeDataSize = store->getVBucket(vbid)->lockCollections().getDataSize(
+                ScopeID::Default);
     } // VBucketPtr scope ends
 
     resetEngineAndWarmup();
@@ -1086,6 +1089,10 @@ TEST_F(CollectionsWarmupTest, warmup) {
               store->getVBucket(vbid)->lockCollections().getHighSeqno(
                       CollectionEntry::meat));
 
+    EXPECT_EQ(scopeDataSize,
+              store->getVBucket(vbid)->lockCollections().getDataSize(
+                      ScopeID::Default));
+
     {
         Item item(StoredDocKey{"meat:beef", CollectionEntry::meat},
                   /*flags*/ 0,

engines/ep/tests/module_tests/collections/scope_data_limit_tests.cc

@@ -18,6 +18,8 @@
 #include "ep_engine.h"
 #include "kv_bucket.h"
 #include "tests/mock/mock_dcp_consumer.h"
+#include "tests/module_tests/collections/collections_test.h"
+#include "tests/module_tests/test_helpers.h"
 
 #include <utilities/test_manifest.h>
 
@@ -218,4 +220,37 @@ TEST_P(CollectionsDcpParameterizedTest, active_updates_limit) {
                       .lock()
                       .getDataLimit(ScopeEntry::shop1)
                       .value());
+}
+
+TEST_F(CollectionsTest, ScopeWithManyCollectionsWarmup) {
+    auto vb = store->getVBucket(vbid);
+
+    CollectionsManifest cm;
+    cm.add(ScopeEntry::shop1);
+    cm.add(CollectionEntry::fruit, ScopeEntry::shop1);
+    cm.add(CollectionEntry::vegetable, ScopeEntry::shop1);
+    cm.add(CollectionEntry::dairy, ScopeEntry::shop1);
+    setCollections(cookie, cm);
+
+    store_items(
+            2, vbid, makeStoredDocKey("f", CollectionEntry::fruit), "value");
+    store_items(2,
+                vbid,
+                makeStoredDocKey("v", CollectionEntry::vegetable),
+                "value");
+    store_items(
+            2, vbid, makeStoredDocKey("d", CollectionEntry::dairy), "value");
+
+    EXPECT_EQ(0, vb->getManifest().lock().getDataSize(ScopeEntry::shop1));
+
+    flushVBucketToDiskIfPersistent(vbid, 4 + 6);
+    auto ds = vb->getManifest().lock().getDataSize(ScopeEntry::shop1);
+    EXPECT_NE(0, ds);
+    vb.reset();
+    resetEngineAndWarmup();
+
+    // Data size comes back the same value
+    EXPECT_EQ(ds,
+              store->getVBucket(vbid)->getManifest().lock().getDataSize(
+                      ScopeEntry::shop1));
 }