Skip to content

Commit 7a2667a

Browse files
owend74daverigby
authored andcommitted
[BP] MB-33957: Change ephemeral eviction policy for cursor dropping tests
[Backport of MB-32099.] The original patch is http://review.couchbase.org/#/c/102806/ with Change-Id: I5a3f6320b6615a0d4866c54dfe30345989689ebb This patch attempts to fix the intermittent cv failure, caused by the pager running and deleting items on an ephemeral bucket. This would cause an unexpected deletion opcode intermittently. This was identified on both "test dcp cursor dropping" and "test dcp cursor dropping (replication)", but not "test dcp cursor dropping backfill". Seeming as these are similar tests, if we see any CV failures like this in the future on the backfill test, the same fix should be applied to it too. Change-Id: I751d4ba3872d4d70f2de0691edb9bfeab5294f92 Reviewed-on: http://review.couchbase.org/108396 Reviewed-by: Dave Rigby <[email protected]> Well-Formed: Build Bot <[email protected]> Tested-by: Build Bot <[email protected]>
1 parent 4b3d201 commit 7a2667a

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

engines/ep/tests/ep_testsuite_dcp.cc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6244,7 +6244,8 @@ BaseTestCase testsuite_testcases[] = {
62446244
create at least 1000 items when our residency
62456245
ratio gets to 90%. See test body for more details. */
62466246
"cursor_dropping_lower_mark=60;cursor_dropping_upper_mark=70;"
6247-
"chk_remover_stime=1;max_size=6291456;chk_max_items=8000;",
6247+
"chk_remover_stime=1;max_size=6291456;chk_max_items=8000;"
6248+
"ephemeral_full_policy=fail_new_data",
62486249

62496250
// TODO RDB: Cannot store any item (ENGINE_ENOMEM).
62506251
// Needs to resize 'max_size' to consider RocksDB
@@ -6259,7 +6260,8 @@ BaseTestCase testsuite_testcases[] = {
62596260
create at least 1000 items when our residency
62606261
ratio gets to 90%. See test body for more details. */
62616262
"cursor_dropping_lower_mark=60;cursor_dropping_upper_mark=70;"
6262-
"chk_remover_stime=1;max_size=6291456;chk_max_items=8000;",
6263+
"chk_remover_stime=1;max_size=6291456;chk_max_items=8000;"
6264+
"ephemeral_full_policy=fail_new_data",
62636265

62646266
// TODO RDB: Cannot store any item (ENGINE_ENOMEM).
62656267
// Needs to resize 'max_size' to consider RocksDB

0 commit comments

Comments
 (0)