CBD-6348: [BP] clang-analyzer: Use after move warnings

Fix warnings reported as "use after move" appearing after upgrade
to clang 15

Change-Id: Ia9eaac4c5a938cb317932421c1b1bdb7adc8eb46
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/234817
Reviewed-by: Pavlos Georgiou <[email protected]>
Well-Formed: Restriction Checker
Tested-by: Trond Norbye <[email protected]>

Author: trondn

daemon/external_auth_manager_thread.cc

@@ -243,7 +243,8 @@ void ExternalAuthManagerThread::setRbacCacheEpoch(
 }
 
 void ExternalAuthManagerThread::processResponseQueue() {
-    auto responses = std::move(incommingResponse);
+    decltype(incommingResponse) responses;
+    responses.swap(incommingResponse);
     while (!responses.empty()) {
         const auto& entry = responses.front();
         auto iter = requestMap.find(entry->opaque);
@@ -262,7 +263,8 @@ void ExternalAuthManagerThread::processResponseQueue() {
     }
 }
 void ExternalAuthManagerThread::purgePendingDeadConnections() {
-    auto pending = std::move(pendingRemoveConnection);
+    decltype(pendingRemoveConnection) pending;
+    pending.swap(pendingRemoveConnection);
     for (const auto& connection : pending) {
         LOG_WARNING_RAW(
                 "External authentication manager died. Expect "

executor/cb3_executorthread.cc

@@ -164,7 +164,7 @@ void CB3ExecutorThread::resetCurrentTask() {
         std::lock_guard<std::mutex> lh(currentTaskMutex);
         // move currentTask so we 'steal' the pointer and ensure currentTask
         // owns nothing.
-        resetThisObject = std::move(currentTask);
+        resetThisObject.swap(currentTask);
     }
     {
         // Freeing of the Task object should be accounted to the engine