Skip to content

Commit 8688b36

Browse files
committed
Remove warning from -Wmaybe-uninitialized
engines/ep/src/dcp/passive_stream.cc:734:9: warning: ‘ret’ may be used uninitialized [-Wmaybe-uninitialized] 734 | if (ret != cb::engine_errc::no_memory) { | ^~ engines/ep/src/dcp/passive_stream.cc:664:21: note: ‘ret’ was declared here 664 | cb::engine_errc ret; | ^~~ protocol/mcbp/request_test.cc:49:77: warning: ‘blob’ may be used uninitialized [-Wmaybe-uninitialized] 49 | auto fe = encodeFrameInfo(request::FrameInfoId(32), {blob, sizeof(blob)}); | ^ Change-Id: I66c3e9052cc269b922daa3b4228db5f6bfbdb87d Reviewed-on: https://review.couchbase.org/c/kv_engine/+/197127 Tested-by: Build Bot <[email protected]> Reviewed-by: Jim Walker <[email protected]>
1 parent 87efeb9 commit 8688b36

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

engines/ep/src/dcp/passive_stream.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -661,7 +661,7 @@ cb::engine_errc PassiveStream::processMessage(MutationConsumerMessage* message,
661661
message->getItem()->setCas();
662662
}
663663

664-
cb::engine_errc ret;
664+
auto ret = cb::engine_errc::failed;
665665
DeleteSource deleteSource = DeleteSource::Explicit;
666666
bool switchComplete = false;
667667
switch (messageType) {

protocol/mcbp/request_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ static std::vector<uint8_t> encodeFrameInfo(request::FrameInfoId id,
4545
}
4646

4747
TEST(Request_ParseFrameExtras, ExtendedIdAndSize) {
48-
uint8_t blob[37];
48+
uint8_t blob[37] = {};
4949
auto fe = encodeFrameInfo(request::FrameInfoId(32), {blob, sizeof(blob)});
5050
std::vector<uint8_t> packet(1024);
5151
RequestBuilder builder({packet.data(), packet.size()});

0 commit comments

Comments
 (0)