Skip to content

Commit 91b91b7

Browse files
committed
Log redaction: Tag SCRAM fallback salt
Whenever the configuration change memcached prints out the old and the new value for the configuration parameter. The scram_fallback_salt should be removed from the logs Change-Id: Iba7888333475cacede2cd84081b20e215f3cb370 Reviewed-on: http://review.couchbase.org/93405 Tested-by: Build Bot <[email protected]> Reviewed-by: Dave Rigby <[email protected]>
1 parent 2955fca commit 91b91b7

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

daemon/settings.cc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
#include "ssl_utils.h"
3333

3434
#include <mcbp/mcbp.h>
35+
#include <utilities/logtags.h>
3536

3637
// the global entry of the settings object
3738
Settings settings;
@@ -1149,7 +1150,9 @@ void Settings::updateSettings(const Settings& other, bool apply) {
11491150
const auto m = getScramshaFallbackSalt();
11501151

11511152
if (o != m) {
1152-
LOG_INFO(R"(Change scram fallback salt from {} to {})", m, o);
1153+
LOG_INFO(R"(Change scram fallback salt from {} to {})",
1154+
cb::logtags::tagUserData(m),
1155+
cb::logtags::tagUserData(o));
11531156
setScramshaFallbackSalt(o);
11541157
}
11551158
}

0 commit comments

Comments
 (0)