CBD-6348: [BP] clang-analyze: Refactor code to get rid of clang-warning

clang-analyzer with clang-15 reported a potential leak in
engines/ep/src/linked_list.cc from create.

This patch improves the readability of the code and as
part of that clang-15 won't get fooled to report a
potential leak.

Change-Id: Icac67eb86f5adcccd3d924a3d9e15e46bfaf4c9e
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/235169
Well-Formed: Restriction Checker
Tested-by: Trond Norbye <[email protected]>
Reviewed-by: Faizan Alam <[email protected]>

Author: trondn

engines/ep/src/linked_list.cc

@@ -439,18 +439,20 @@ OrderedLL::iterator BasicLinkedList::purgeListElem(OrderedLL::iterator it,
 
 std::unique_ptr<BasicLinkedList::RangeIteratorLL>
 BasicLinkedList::RangeIteratorLL::create(BasicLinkedList& ll, bool isBackfill) {
-    std::unique_ptr<BasicLinkedList::RangeIteratorLL> pRangeItr;
+    std::unique_ptr<RangeIteratorLL> pRangeItr;
     {
         std::lock_guard<std::mutex> listWriteLg(ll.getListWriteLock());
 
         /* Note: cannot use std::make_unique because the constructor of
            RangeIteratorLL is private */
-        pRangeItr = std::unique_ptr<BasicLinkedList::RangeIteratorLL>(
-                new BasicLinkedList::RangeIteratorLL(
-                        ll, listWriteLg, isBackfill));
+        pRangeItr.reset(new RangeIteratorLL(ll, listWriteLg, isBackfill));
     }
 
-    return pRangeItr->tryLater() ? nullptr : std::move(pRangeItr);
+    if (pRangeItr->tryLater()) {
+        pRangeItr.reset();
+    }
+
+    return pRangeItr;
 }
 
 BasicLinkedList::RangeIteratorLL::RangeIteratorLL(