CBD-6348: [BP] Disable fmt format check for WIN32

Disable it on win32 as it didn't work on 2019 and doesn't
work on 2022 (which we're trying to upgrade to) and not tie it
to the compiler so we'll have to fight the same battle the next
time

Change-Id: Ibfe20a700d641a6319259f400ce4da4b3b803a28
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/234971
Well-Formed: Restriction Checker
Reviewed-by: Mohammad Zaeem <[email protected]>
Tested-by: Trond Norbye <[email protected]>

Author: trondn

engines/ep/src/bucket_logger.h

@@ -221,10 +221,10 @@ std::shared_ptr<BucketLogger>& getGlobalBucketLogger();
 // Various implementation details for the EP_LOG_<level> macros below.
 // End-users shouldn't use these directly, instead use EP_LOG_<level>.
 
-// Visual Studio prior to 2019 doens't correctly handle the constexpr
+// Visual Studio doens't correctly handle the constexpr
 // format string checking - see https://github.com/fmtlib/fmt/issues/2328.
 // As such, only apply the compile-time check for non-MSVC or VS 2019+
-#if FMT_MSC_VER && FMT_MSC_VER < 1920
+#if WIN32
 #define CHECK_FMT_STRING(fmt) fmt
 #else
 #define CHECK_FMT_STRING(fmt) FMT_STRING(fmt)

logger/logger.h

@@ -143,10 +143,10 @@ bool isInitialized();
 
 } // namespace cb::logger
 
-// Visual Studio prior to 2019 doesn't correctly handle the constexpr
+// Visual Studio doesn't correctly handle the constexpr
 // format string checking - see https://github.com/fmtlib/fmt/issues/2328.
-// As such, only apply the compile-time check for non-MSVC or VS 2019+
-#if FMT_MSC_VER && FMT_MSC_VER < 1920
+// As such, only apply the compile-time check for non-MSVC
+#ifdef WIN32
 #define CHECK_FMT_STRING(fmt) fmt
 #else
 #define CHECK_FMT_STRING(fmt) FMT_STRING(fmt)