Skip to content

Commit 97ba0d7

Browse files
BenHuddlestondaverigby
authored andcommitted
MB-33332: Update SV CommittedState comment
Change-Id: I7be34bcbc7144d16746a3b4b2b414fb5521e05a1 Reviewed-on: http://review.couchbase.org/109991 Reviewed-by: Dave Rigby <[email protected]> Tested-by: Build Bot <[email protected]>
1 parent 80fa82e commit 97ba0d7

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

include/memcached/types.h

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,8 @@ std::string to_string(DeleteSource deleteSource);
181181
/**
182182
* The committed state of the Item.
183183
*
184-
* Consists of four states: CommittedViaMutation, CommittedViaPrepare
185-
* Pending and PreparedMaybeVisible.
184+
* Consists of six states: CommittedViaMutation, CommittedViaPrepare
185+
* Pending, PreparedMaybeVisible, PrepareAborted, and PrepareCommitted.
186186
* The first two are generally considered as the same 'Committed' state
187187
* by external observers, but internally we need to differentiate between
188188
* them to write to disk / send over DCP hence having two different states.
@@ -192,6 +192,10 @@ std::string to_string(DeleteSource deleteSource);
192192
* Committed (but haven't yet been Committed locally) are marked as
193193
* PreparedMaybeVisible.
194194
*
195+
* PrepareAborted and PrepareCommitted are used to identify prepares that exist
196+
* in the HashTable after they have been completed which is required for
197+
* Ephemeral.
198+
*
195199
* Used in a bitfield in StoredValue hence explicit values for enums required.
196200
*/
197201
enum class CommittedState : char {

0 commit comments

Comments
 (0)