Skip to content

Commit aa9be74

Browse files
Sriram Ganesantrondn
authored andcommitted
MB-28685: Don't run some tests when the compression mode is not 'off'
Some tests explicitly require the compression mode to be 'off'. So, if the compression mode is not 'off', return without executing the test. Change-Id: I8974cbc71f2a78908ccbef1ec69bbd30f227a453 Reviewed-on: http://review.couchbase.org/93563 Reviewed-by: Jim Walker <[email protected]> Tested-by: Build Bot <[email protected]>
1 parent 09771ed commit aa9be74

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

engines/ep/tests/module_tests/evp_store_single_threaded_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1889,7 +1889,7 @@ TEST_F(WarmupTest, fetchDocInDifferentCompressionModes) {
18891889
store_item(vbid, makeStoredDocKey("key1"), valueData);
18901890
flush_vbucket_to_disk(vbid);
18911891

1892-
resetEngineAndWarmup();
1892+
resetEngineAndWarmup("compression_mode=off");
18931893
auto item1 = store->get(makeStoredDocKey("key1"), vbid, nullptr, {});
18941894
ASSERT_EQ(ENGINE_SUCCESS, item1.getStatus());
18951895
auto info1 = engine->getItemInfo(*item1.item);

engines/ep/tests/module_tests/evp_store_with_meta.cc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -515,6 +515,11 @@ TEST_P(AllWithMetaTest, invalid_extlen) {
515515
// Test to verify that a set with meta will store the data
516516
// as uncompressed in the hash table
517517
TEST_F(WithMetaTest, storeUncompressedInOffMode) {
518+
519+
// Return if the bucket compression mode is not 'off'
520+
if (engine->getCompressionMode() != BucketCompressionMode::Off) {
521+
return;
522+
}
518523
std::string valueData{R"({"aaaaaaaaa":10000000000})"};
519524
auto item = makeCompressibleItem(vbid, makeStoredDocKey("key"), valueData,
520525
PROTOCOL_BINARY_RAW_BYTES, true);

0 commit comments

Comments
 (0)