Merge commit neo/c88c04aa0 into master

* c88c04a [BP MB-52276] MB-53657: Notify DCP frontend at CM::queueSetVBState()
* f6ba8a7 [BP MB-52276] MB-53657: Notify DCP frontend if cursor jumps into new checkpoint
* 25fd6d3 [BP MB-52276] MB-53657: Don't check for stream-active in Prod::notifySeqnoAvailable
* 065ecd2 [BP MB-52276] MB-53657: Remove unused seqno arg in KVBucket::notifyReplication
* 39f73a3 [BP MB-52276] MB-53657: Remove unused seqno arg in DcpConnMap::notifySeqnoAvailable
* 451e0bd [BP MB-52276] MB-53657: Remove unused seqno arg in DcpProducer::notifySeqnoAvailable
* 8801765 MB-39344: Fix sporadic ep_testsuite failures
* 0c99362 [BP] MB-39344: Simplify logic in CM::registerCursorBySeqno
* 12eb97b [BP] MB-39344: Allow expelling all non-meta items in checkpoint
* 6683344 [BP] MB-39344: Add test coverage for Checkpoint::getMinimumCursorSeqno
* 0059ff8 [BP] MB-39344: Fix computation in Checkpoint::getHighSeqno()
* eec7031 [BP] MB-39344: Remove Vbid arg from CM::createCheckpointMetaItem
* d557f64 [BP] MB-39344: Rename createCheckpointItem() into createCheckpointMetaItem()
* 9606a0b [BP] MB-39344: De-inline Checkpoint::getHighSeqno()

Change-Id: I0ca75a339e7cfbb68e57a49876c1b964a5da17c8

Author: paolococchi

engines/ep/tests/module_tests/checkpoint_remover_test.cc

@@ -633,22 +633,22 @@ TEST_P(CheckpointRemoverEPTest,
         cm->incrCursor(*cursor);
     }
 
-    // Can now expel the 2 items in (ckpt_start, cursor)
+    // Can now expel the 2 items in (ckpt_start, cursor]
     auto result = cm->expelUnreferencedCheckpointItems();
 
-    EXPECT_EQ(2, result.count);
+    EXPECT_EQ(3, result.count);
 
     /* items in first checkpoint
      *
      *   dummy
      *   chk start
-     *   key_1
      *   key_2
+     *   chk end
      */
 
     afterCount = getItemsWithCursor("Cursor4", 0, true).size();
 
-    EXPECT_EQ(beforeCount - 2, afterCount);
+    EXPECT_EQ(beforeCount - 3, afterCount);
 }
 
 TEST_P(CheckpointRemoverEPTest, earliestCheckpointSelectedCorrectly) {

engines/ep/tests/module_tests/checkpoint_test.cc

@@ -2501,7 +2501,7 @@ TEST_P(ReplicaCheckpointTest, ExpelCheckpointItemsDisk) {
 
 // Test that we correctly handle duplicates, where the initial version of the
 // document has been expelled.
-TEST_P(CheckpointTest, ExpelCheckpointItemsWithDuplicateTest) {
+TEST_P(CheckpointTest, ExpelCheckpointItemsWithDuplicate) {
     const int itemCount{3};
 
     for (auto ii = 0; ii < itemCount; ++ii) {