Skip to content

Commit b66f84c

Browse files
committed
MB-43478: Relax RR checks in the ReplicaEvictedBeforeActive test
The test is very sensible to minor differences of how much memory the ItemPager frees up in different runs, which makes the test failing sometimes. But, the original purpose of the test is just ensuring that Replica VBs are ejected before Active VBs, so just verify that. Change-Id: Idedec7485e616392caf32663ec546397115cffbe Reviewed-on: http://review.couchbase.org/c/kv_engine/+/143520 Tested-by: Build Bot <[email protected]> Reviewed-by: Jim Walker <[email protected]>
1 parent c9f24e3 commit b66f84c

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

engines/ep/tests/module_tests/item_pager_test.cc

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1017,12 +1017,10 @@ TEST_P(STItemPagerTest, ReplicaEvictedBeforeActive) {
10171017
EXPECT_EQ(100, getRRPercent(*store->getVBucket(vbid)))
10181018
<< vbid << " not fully resident after eviction";
10191019
}
1020-
// Confirm the replica RR is "low"
1021-
// the replica RR could be constrained further, but checking
1022-
// it is below 20% to avoid making the test too sensitive to small
1023-
// changes in base memory usage.
1020+
1021+
// Confirm the replica RR is lower that active RR
10241022
for (const auto vbid : replicaVBs) {
1025-
EXPECT_LT(getRRPercent(*store->getVBucket(vbid)), 20)
1023+
EXPECT_LT(getRRPercent(*store->getVBucket(vbid)), 100)
10261024
<< vbid << " has residency higher than expected";
10271025
}
10281026
}

0 commit comments

Comments
 (0)