[Cleanup] Remove logging from EPE::getConnHandler

The packet validator already verifies that the connection
is set up as a DCP connection before calling into the
engine (the packet validator did not check for DCP
in the cases where we didn't want the logging)

Change-Id: Ib6e805c2292c489e6e2597ccea81da2f2b586a1f
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/140961
Tested-by: Build Bot <[email protected]>
Reviewed-by: Dave Rigby <[email protected]>

Author: trondn

engines/ep/src/ep_engine.cc

@@ -1425,7 +1425,7 @@ ENGINE_ERROR_CODE EventuallyPersistentEngine::get_failover_log(
         return ENGINE_EWOULDBLOCK;
     }
 
-    ConnHandler* conn = engine->getConnHandler(cookie, false);
+    ConnHandler* conn = engine->getConnHandler(cookie);
     // Note: (conn != nullptr) only if conn is a DCP connection
     if (conn) {
         auto* producer = dynamic_cast<DcpProducer*>(conn);
@@ -6231,21 +6231,16 @@ ENGINE_ERROR_CODE EventuallyPersistentEngine::dcpAddStream(const void* cookie,
     return errCode;
 }
 
-ConnHandler* EventuallyPersistentEngine::getConnHandler(const void* cookie,
-                                                        bool logNonExistent) {
+ConnHandler* EventuallyPersistentEngine::getConnHandler(const void* cookie) {
     auto* iface = getDcpConnHandler(cookie);
     if (iface) {
         auto* handler = dynamic_cast<ConnHandler*>(iface);
         if (handler) {
             return handler;
         }
-    }
-
-    if (logNonExistent) {
-        auto li = serverApi->cookie->get_log_info(cookie);
-        EP_LOG_WARN("{}: Invalid streaming connection: cookie:{}",
-                    li.first,
-                    cb::to_hex(uint64_t(cookie)));
+        throw std::logic_error(
+                "EventuallyPersistentEngine::getConnHandler(): The registered "
+                "connection handler is not a ConnHandler");
     }
 
     return nullptr;
@@ -6444,7 +6439,7 @@ ENGINE_ERROR_CODE EventuallyPersistentEngine::getAllVBucketSequenceNumbers(
         return ENGINE_ERROR_CODE(accessStatus);
     }
 
-    auto* connhandler = getConnHandler(cookie, false);
+    auto* connhandler = getConnHandler(cookie);
     bool supportsSyncWrites = connhandler && connhandler->isSyncWritesEnabled();
 
     std::vector<char> payload;

engines/ep/src/ep_engine.h

@@ -733,10 +733,9 @@ class EventuallyPersistentEngine : public EngineIface, public DcpIface {
      * Get the connection handler for the provided cookie
      *
      * @param cookie the cookie to look up
-     * @param logNonExistent Should we log if we don't find a connection handler
      * @return the pointer to the connection handler if found, nullptr otherwise
      */
-    ConnHandler* getConnHandler(const void* cookie, bool logNonExistent = true);
+    ConnHandler* getConnHandler(const void* cookie);
 
     /**
      * Method to add a cookie to allKeysLookups to store the result of the