MB-45378: Statically link all engines

Two issues[1,2] have so far been identified with Folly when multiple
instances of Folly end up within the same process - i.e. multiple
executables / DSOs present in memcached process.

Both issues can be fixed by changing the visibility of certain folly
symbols, but our current usage model (linking into shared libraries
with visibility=hidden) is not the common model for Folly and hence the
concern that this isn't a stable or safe way to continue to consume
Folly.

As such, move as much as possible of our linking to be static -
specifically any library which uses Folly should be linked statically.

This patch does this for all engines, so they are part of the
memcached binary.

[1]: facebook/folly#1431
[2]: facebook/folly#1558

Change-Id: Ic9633db89e9e769146e7869a5122b6720ea2e1eb
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/147715
Reviewed-by: Dave Rigby <[email protected]>
Tested-by: Build Bot <[email protected]>

Author: trondn

engines/crash_engine/CMakeLists.txt

@@ -1,7 +1,2 @@
-ADD_LIBRARY(crash_engine SHARED crash_engine.cc)
-SET_TARGET_PROPERTIES(crash_engine PROPERTIES PREFIX "")
-TARGET_LINK_LIBRARIES(crash_engine engine_utilities platform)
-INSTALL(TARGETS crash_engine
-        RUNTIME DESTINATION bin
-        LIBRARY DESTINATION lib
-        ARCHIVE DESTINATION lib)
+add_library(crash_engine STATIC crash_engine.cc)
+target_link_libraries(crash_engine engine_utilities platform)

engines/default_engine/CMakeLists.txt

@@ -1,4 +1,4 @@
-ADD_LIBRARY(default_engine SHARED
+ADD_LIBRARY(default_engine STATIC
             assoc.cc
             assoc.h
             default_engine.cc

engines/ep/CMakeLists.txt

@@ -378,7 +378,7 @@ ADD_LIBRARY(ep_objs OBJECT
 SET_PROPERTY(TARGET ep_objs PROPERTY POSITION_INDEPENDENT_CODE 1)
 add_sanitizers(ep_objs)
 
-ADD_LIBRARY(ep SHARED $<TARGET_OBJECTS:ep_objs>)
+ADD_LIBRARY(ep STATIC $<TARGET_OBJECTS:ep_objs>)
 
 if (NOT WIN32)
   # Enable the more efficient ThreadLocalStorage model

engines/utilities/CMakeLists.txt

@@ -1,11 +1,2 @@
-ADD_LIBRARY(engine_utilities SHARED engine_error.cc)
-TARGET_LINK_LIBRARIES(engine_utilities platform)
-
-GENERATE_EXPORT_HEADER(engine_utilities
-                       EXPORT_MACRO_NAME ENGINE_UTILITIES_PUBLIC_API
-                       EXPORT_FILE_NAME ${PROJECT_BINARY_DIR}/include/memcached/engine_utilities_visibility.h)
-
-INSTALL(TARGETS engine_utilities
-        RUNTIME DESTINATION bin
-        LIBRARY DESTINATION lib
-        ARCHIVE DESTINATION lib)
+add_library(engine_utilities STATIC engine_error.cc)
+target_link_libraries(engine_utilities platform)

include/memcached/engine_error.h

@@ -10,18 +10,11 @@
  */
 #pragma once
 
-#include <memcached/engine_utilities_visibility.h>
 #include <platform/dynamic.h>
 
 #include <iosfwd>
 #include <system_error>
 
-#ifdef _MSC_VER
-// We need to add the right __declspec magic to the system types
-// to avoid msvc to spit out warnings
-class ENGINE_UTILITIES_PUBLIC_API std::system_error;
-#endif
-
 namespace cb {
 /**
  * The Error enum contains all of the various error codes the engines
@@ -143,10 +136,9 @@ enum class engine_errc {
  *
  * @return The one and only instance of the error object
  */
-ENGINE_UTILITIES_PUBLIC_API
 const std::error_category& engine_error_category() NOEXCEPT;
 
-class ENGINE_UTILITIES_PUBLIC_API engine_error : public std::system_error {
+class engine_error : public std::system_error {
 public:
     engine_error(engine_errc ev, const std::string& what_arg)
         : system_error(int(ev), engine_error_category(), what_arg) {}
@@ -159,14 +151,11 @@ static inline std::error_condition make_error_condition(engine_errc e) {
     return std::error_condition(int(e), engine_error_category());
 }
 
-ENGINE_UTILITIES_PUBLIC_API
 std::string to_string(engine_errc ev);
 
 // GoogleTest printing function.
-ENGINE_UTILITIES_PUBLIC_API
 void PrintTo(engine_errc ev, ::std::ostream* os);
 // For checkeqfn
-ENGINE_UTILITIES_PUBLIC_API
 std::ostream& operator<<(std::ostream& os, cb::engine_errc ec);
 } // namespace cb
 

include/statistics/cbstat_collector.h

@@ -26,7 +26,7 @@ struct ServerApi;
  * Formats all stats to text and immediately calls the provided
  * addStatFn.
  */
-class STATISTICS_PUBLIC_API CBStatCollector : public StatCollector {
+class CBStatCollector : public StatCollector {
 public:
     /**
      * Construct a collector which calls the provided addStatFn

include/statistics/collector.h

@@ -14,7 +14,6 @@
 #include "definitions.h"
 
 #include <platform/histogram.h>
-#include <statistics/visibility.h>
 
 #include <optional>
 #include <string>
@@ -143,7 +142,7 @@ class BucketStatCollector;
  * disk_size{bucket="bucketName", scope="0x0"} 123
  *
  */
-class STATISTICS_PUBLIC_API StatCollector {
+class StatCollector {
 public:
     using Labels = std::unordered_map<std::string_view, std::string_view>;
 

include/statistics/definitions.h

@@ -76,7 +76,7 @@ class CBStatsKey {
  * stats.def.h, but can also be created directly as a fallback until
  * all stats have been transitioned to stats.def.h.
  */
-struct STATISTICS_PUBLIC_API StatDef {
+struct StatDef {
     using Labels = std::unordered_map<std::string_view, std::string_view>;
     /**
      * Construct from char* to minimize code change while migrating to
@@ -188,7 +188,7 @@ struct STATISTICS_PUBLIC_API StatDef {
 #define STAT(statName, ...) statName,
 #define CBSTAT(statName, ...) statName,
 #define PSTAT(statName, ...) statName,
-enum class STATISTICS_PUBLIC_API Key {
+enum class Key {
 #include "stats.def.h"
 
     enum_max

include/statistics/labelled_collector.h

@@ -45,7 +45,7 @@
  * adding additional labels to every addStat call.
  *
  */
-class STATISTICS_PUBLIC_API LabelledStatCollector : public StatCollector {
+class LabelledStatCollector : public StatCollector {
 public:
     // Allow usage of the "helper" methods defined in the base type.
     // They would otherwise be shadowed
@@ -147,7 +147,7 @@ class ColStatCollector;
  * label) to add stats for a single bucket, regardless of stat backend
  * implementation.
  */
-class STATISTICS_PUBLIC_API BucketStatCollector : public LabelledStatCollector {
+class BucketStatCollector : public LabelledStatCollector {
 public:
     BucketStatCollector(const StatCollector& parent, std::string_view bucket);
     [[nodiscard]] ScopeStatCollector forScope(std::string_view scopeName,
@@ -159,7 +159,7 @@ class STATISTICS_PUBLIC_API BucketStatCollector : public LabelledStatCollector {
  *
  * See BucketStatCollector.
  */
-class STATISTICS_PUBLIC_API ScopeStatCollector : public LabelledStatCollector {
+class ScopeStatCollector : public LabelledStatCollector {
 public:
     ScopeStatCollector(const BucketStatCollector& parent,
                        std::string_view scopeName,
@@ -176,7 +176,7 @@ class STATISTICS_PUBLIC_API ScopeStatCollector : public LabelledStatCollector {
  *
  * See BucketStatCollector.
  */
-class STATISTICS_PUBLIC_API ColStatCollector : public LabelledStatCollector {
+class ColStatCollector : public LabelledStatCollector {
 public:
     ColStatCollector(const ScopeStatCollector& parent,
                      std::string_view collectionName,

include/statistics/prometheus.h

@@ -18,7 +18,6 @@
 
 #include <memcached/engine_error.h>
 #include <platform/socket.h>
-#include <statistics/visibility.h>
 
 namespace prometheus {
 // forward declaration
@@ -45,18 +44,14 @@ using GetStatsCallback =
  * @throws std::bad_alloc for memory allocation failures
  * @throws std::runtime_errors if we failed to start the exporter service
  */
-STATISTICS_PUBLIC_API
 nlohmann::json initialize(const std::pair<in_port_t, sa_family_t>& config,
                           GetStatsCallback getStatsCB,
                           AuthCallback authCB);
 
-STATISTICS_PUBLIC_API
 void shutdown();
 
-STATISTICS_PUBLIC_API
 std::pair<in_port_t, sa_family_t> getRunningConfig();
 
-STATISTICS_PUBLIC_API
 nlohmann::json getRunningConfigAsJson();
 
 /**