Skip to content

Commit c029c0f

Browse files
daverigbypaolococchi
authored andcommitted
[BP] MB-52847: Skip ep_overhead check in ep_testsuite 'disk>RAM delete golden path'
ep_overhead (the amount of memory overhead in Checkpoint and related structures) can decrease during this test if for example an entire Checkpoint is persisted and all items from it can be discarded. As such, remove the check on it as it is invalid. Change-Id: I195c17df2f1f0a0f0239885376248661dcbb7b66 Reviewed-on: https://review.couchbase.org/c/kv_engine/+/200042 Reviewed-by: Jim Walker <[email protected]> Tested-by: Paolo Cocchi <[email protected]> Well-Formed: Restriction Checker
1 parent f3da57e commit c029c0f

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

engines/ep/tests/ep_testsuite.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4302,7 +4302,6 @@ static enum test_result test_disk_gt_ram_golden(EngineIface* h) {
43024302

43034303
static enum test_result test_disk_gt_ram_paged_rm(EngineIface* h) {
43044304
// Check/grab initial state.
4305-
int overhead = get_int_stat(h, "ep_overhead");
43064305
const auto initial_enqueued = get_int_stat(h, "ep_total_enqueued");
43074306

43084307
// Store some data and check post-set state.
@@ -4313,9 +4312,6 @@ static enum test_result test_disk_gt_ram_paged_rm(EngineIface* h) {
43134312
checkeq(initial_enqueued + 1,
43144313
get_int_stat(h, "ep_total_enqueued"),
43154314
"Expected total_enqueued to increase by 1 after storing 1 value");
4316-
checkge(get_int_stat(h, "ep_overhead"),
4317-
overhead,
4318-
"Fell below initial overhead.");
43194315

43204316
// Evict the data.
43214317
evict_key(h, "k1");

0 commit comments

Comments
 (0)