kvstore_test: Set delete item to deleted

In KVStoreParamTest/TestPersistenceCallbacksForDel; the item which was
deleted was incorrectly not set to deleted. This is incorrect; the
deleted flag should be true for any item which is a delete.

Change-Id: Ibd63743de79f8f84a808638d0594e2614bef98af
Reviewed-on: http://review.couchbase.org/93763
Tested-by: Build Bot <[email protected]>
Reviewed-by: Trond Norbye <[email protected]>

Author: daverigby

engines/ep/src/rocksdb-kvstore/rocksdb-kvstore.cc

@@ -638,6 +638,10 @@ void RocksDBKVStore::reset(uint16_t vbucketId) {
 
 void RocksDBKVStore::del(const Item& item,
                          Callback<TransactionContext, int>& cb) {
+    if (!item.isDeleted()) {
+        throw std::invalid_argument(
+                "RocksDBKVStore::del item to delete is not marked as deleted.");
+    }
     if (!in_transaction) {
         throw std::logic_error(
                 "RocksDBKVStore::del: in_transaction must be true to perform a "

engines/ep/tests/module_tests/kvstore_test.cc

@@ -1943,6 +1943,7 @@ TEST_P(KVStoreParamTest, TestPersistenceCallbacksForDel) {
     int delCount = 1;
     EXPECT_CALL(mpc, callback(_, delCount)).Times(0);
 
+    item.setDeleted();
     kvstore->del(item, mpc);
 
     // Expect that the DEL callback will be called once after `commit`