MB-42358: Pass path to memory-tracking test plugin on command-line

Using an absolute path, passed on the comand-line bypasses any issues
with RPATH/RUNPATH differences.

Change-Id: I961548671f280e7fdf6d025c5a82ab7ae9661c3e
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/139385
Tested-by: Build Bot <[email protected]>
Reviewed-by: Paolo Cocchi <[email protected]>
Well-Formed: Build Bot <[email protected]>

Author: jameseh96

tests/memory_tracking_test/CMakeLists.txt

@@ -1,21 +1,13 @@
 IF (NOT MEMORY_ALLOCATOR STREQUAL "system")
-  # Need to ensure that the directory containing
-  # memcached_memory_tracking_test is added to the RPATH so we can
-  # successfully dlopen() the plugin.
-  LINK_DIRECTORIES(${Memcached_BINARY_DIR})
-
   ADD_EXECUTABLE(memcached_memory_tracking_test
     $<TARGET_OBJECTS:memory_tracking>
     memory_tracking_test.cc)
   TARGET_LINK_LIBRARIES(memcached_memory_tracking_test memcached_logger platform gtest ${MALLOC_LIBRARIES})
-  ADD_TEST(NAME memcached-memory-tracking COMMAND memcached_memory_tracking_test)
+  ADD_TEST(NAME memcached-memory-tracking
+    COMMAND memcached_memory_tracking_test $<TARGET_FILE:memcached_memory_tracking_plugin>)
+  ADD_DEPENDENCIES(memcached_memory_tracking_test memcached_memory_tracking_plugin)
 
   ADD_LIBRARY(memcached_memory_tracking_plugin MODULE
               memory_tracking_plugin.cc)
   TARGET_LINK_LIBRARIES(memcached_memory_tracking_plugin platform)
-  SET_TARGET_PROPERTIES(memcached_memory_tracking_plugin PROPERTIES PREFIX "")
-  IF(APPLE)
-    SET_TARGET_PROPERTIES(memcached_memory_tracking_plugin PROPERTIES
-      SUFFIX ".dylib")
-  ENDIF(APPLE)
 ENDIF (NOT MEMORY_ALLOCATOR STREQUAL "system")

tests/memory_tracking_test/memory_tracking_test.cc

@@ -34,6 +34,9 @@
 // via DCE.
 char* p;
 
+/// Path to plugin to be loaded via dlopen.
+const char* pluginPath = nullptr;
+
 class MemoryTrackerTest : public ::testing::Test {
 public:
     // callback function for when memory is allocated.
@@ -131,8 +134,7 @@ void MemoryTrackerTest::AccountingTestThread(void* arg) {
     // Test memory allocations performed from another shared library loaded
     // at runtime.
     char* errmsg = nullptr;
-    cb_dlhandle_t plugin = cb_dlopen("memcached_memory_tracking_plugin",
-                                     &errmsg);
+    cb_dlhandle_t plugin = cb_dlopen(pluginPath, &errmsg);
     EXPECT_NE(plugin, nullptr);
 
     // dlopen()ing a plugin can allocate memory. Reset alloc_size.
@@ -219,6 +221,13 @@ TEST_F(MemoryTrackerTest, mallocUsableSize) {
 int main(int argc, char** argv) {
     ::testing::InitGoogleTest(&argc, argv);
 
+    if (argc != 2) {
+        std::cerr << "Usage: <memory_tracking_test> "
+                     "<path_to_memory_tracking_plugin>\n";
+        return 1;
+    }
+    pluginPath = argv[1];
+
     AllocHooks::initialize();
 
     return RUN_ALL_TESTS();