CBD-6348: [BP] clang-tidy: used after it was moved [bugprone-use-after-move]

Change-Id: I8977a2b3dcd64ae50f5f018faf29add363ddee17
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/234818
Well-Formed: Restriction Checker
Reviewed-by: Pavlos Georgiou <[email protected]>
Tested-by: Trond Norbye <[email protected]>

Author: trondn

engines/ep/src/ep_engine.cc

@@ -4255,7 +4255,7 @@ struct ConnPerStreamStatBuilder {
     ConnPerStreamStatBuilder(DcpStatsOptions options)
         : options(std::move(options)) {
         // The stream stats format is required to emit stream stats.
-        Expects(options.getStreamStatsFormat().has_value());
+        Expects(this->options.getStreamStatsFormat().has_value());
     }
 
     /**

protocol/connection/client_mcbp_commands.cc

@@ -2103,10 +2103,10 @@ BinprotReturnMetaCommand::BinprotReturnMetaCommand(
               cb::mcbp::ClientOpcode::ReturnMeta, d.info.id, d.value),
       doc(std::move(d)) {
     extras.setMutationType(type);
-    extras.setExpiration(d.info.expiration);
-    extras.setFlags(d.info.flags);
-    setCas(d.info.cas);
-    setDatatype(d.info.datatype);
+    extras.setExpiration(doc.info.expiration);
+    extras.setFlags(doc.info.flags);
+    setCas(doc.info.cas);
+    setDatatype(doc.info.datatype);
 }
 
 void BinprotReturnMetaCommand::encode(std::vector<uint8_t>& buf) const {

statistics/statdef.cc

@@ -27,7 +27,7 @@ StatDef::StatDef(CBStatsKey cbstatsKey,
       type(type),
       labels(std::move(labels)) {
     if (metricFamily.empty()) {
-        metricFamily = std::string(cbstatsKey);
+        metricFamily = std::string(this->cbstatsKey);
     }
     metricFamily += unit.getSuffix();
 }