Remove unused add_stat functions

Change-Id: Id5183bf38194d37069aa73e7ef33a1aaac78c8a2
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/200839
Reviewed-by: Vesko Karaganev <[email protected]>
Tested-by: Build Bot <[email protected]>

Author: trondn

daemon/protocol/mcbp/stats_context.cc

@@ -47,41 +47,13 @@
 using namespace std::string_view_literals;
 
 /*************************** ADD STAT CALLBACKS ***************************/
-
-// Generic add_stat<T>. Uses std::to_string which requires heap allocation.
-template <typename T>
-void add_stat(Cookie& cookie,
-              const AddStatFn& add_stat_callback,
-              const char* name,
-              const T& val) {
-    add_stat_callback(name, std::to_string(val), &cookie);
-}
-
-void add_stat(Cookie& cookie,
-              const AddStatFn& add_stat_callback,
-              const char* name,
-              const std::string& value) {
-    add_stat_callback(name, value, cookie);
-}
-
-void add_stat(Cookie& cookie,
-              const AddStatFn& add_stat_callback,
-              const char* name,
-              const char* value) {
+static void add_stat(Cookie& cookie,
+                     const AddStatFn& add_stat_callback,
+                     std::string_view name,
+                     std::string_view value) {
     add_stat_callback(name, value, cookie);
 }
 
-void add_stat(Cookie& cookie,
-              const AddStatFn& add_stat_callback,
-              const char* name,
-              const bool value) {
-    if (value) {
-        add_stat(cookie, add_stat_callback, name, "true");
-    } else {
-        add_stat(cookie, add_stat_callback, name, "false");
-    }
-}
-
 static void append_stats(std::string_view key,
                          std::string_view value,
                          Cookie& cookie) {
@@ -658,7 +630,7 @@ static cb::engine_errc stat_runtimes_executor(const std::string& arg,
                              .isEmpty()) {
                     add_stat(cookie,
                              appendStatsFn,
-                             GlobalTask::getTaskIdString(id).c_str(),
+                             GlobalTask::getTaskIdString(id),
                              stats.taskRuntimeHistogram[static_cast<int>(id)]
                                      .to_string());
                 }
@@ -683,7 +655,7 @@ static cb::engine_errc stat_scheduler_executor(const std::string& arg,
                              .isEmpty()) {
                     add_stat(cookie,
                              appendStatsFn,
-                             GlobalTask::getTaskIdString(id).c_str(),
+                             GlobalTask::getTaskIdString(id),
                              stats.taskSchedulingHistogram[static_cast<int>(id)]
                                      .to_string());
                 }