MB-30303: Subdoc regression tests for backtick un-escaping issue

Regression tests for how KV-Engine subdoc API uses subjson to parse
backticked escaped paths.

(Note: MB-30303 is the 5.1.x backport of MB-30278).

Change-Id: I42a144ba3f37c38d3e4ca0f8990652cda85011c2
Reviewed-on: http://review.couchbase.org/97313
Well-Formed: Build Bot <[email protected]>
Tested-by: Build Bot <[email protected]>
Reviewed-by: Jim Walker <[email protected]>

Author: daverigby

tests/testapp/testapp_subdoc.cc

@@ -2206,6 +2206,34 @@ TEST_P(McdTestappTest, SubdocUTF8ValTest) {
     validate_object("dict", "{ \"key1\": \"Ẇ̴̷̦͔͖͚̝̟̋̽ͪ̾ͤ̈́ͯͮͮ̀͗̌ͭ̾͜h̨̥̞͖̬̠͍͖̘̹͎͌̇̂̃ͯͣ͗̆̌̑ͨ̍̊ͪ̆̾̆̚͟͞ȧ̛̰̞̗̞̬̣̹͎̰̝͍͈̮̖̘̫̤̟͆̈́̒͗ͦ̋̓̌̊̋͝ͅţ͒ͮ͋̋̔̽ͥ̂ͭ̒̉̔̃ͫ̌̆̆҉̹͙̟̩̖̩̹̳̜͚̜̜ ͎̲͕̺̔̿̀͒̈́̏̌ͬͫ͒͂ͩͦ̀͝â̢̡̘̫̮̞̩̰̎ͨ̾ͤ̈́͑̉̈ͧ͆̃ͩ͆̚͡ ̧̢̛̙͔̰̹̲̱͔̤̝͖̥͚͓̲̪̯̟̖̏͒̽ͬ̂ͫͩͭ͋̏͊̽͗͊̀ͭ̋͘c̵̴͐̉̇͂̋ͬ̇̃͊ͨ͗̆̄̊́͏̡̡̫̦̦͉̼̙̜͉̯̮̪̫͍̩̼̘̫̻͍o̸̷͕̭̼̺̤͖͚̯̪̥̘̪̼̝̩̮͕̥̟̐͒̏ͭͦͮ̒ͧ̔̉̅̂͜͢͡o̷̢̡͕̟͓̺͚̟̱̜̻͇̘͍̤͓̲ͣͫ̾͛͗̅̐̏͑͆͌̀͜ͅͅͅl̴̡̙̹͖̈̄̌͒ͣ͒̅̏̕ ͛̐̿͋ͦ͛͌̄ͫ̒ͪ͊̀ͤ̀̿͏̶̡҉҉̤͎͖v̸̵̱͇̲͎̩͚̩͈̙̜̳̞̭̯̩̻̮̪ͯ̋̔͗̃̊ͬͮ̄̃͛̂̒̍͘͘a̦̝͇̙̬̬̰̪͙̗̟͙̝̬͛͂͑ͣ̓͑̏ͤ̑̀̚̚͘l͊̔́͋̋ͫ̈́̿̈̉̀͏̡͍͇̲̙̺̮͠uͬ̄̋̔ͪͧͥ͛ͭ̏̅ͫ͊̚͏̧͈̠̱͇͉̦̫͎͠ę̸͔̯̭̤͕̱͈̖͖̯̭̞͈͖ͨ̑̌̓̈ͮ͂̆̀͟ͅ\" }");
 }
 
+// MB-30278: Perform a DICT_ADD followed by SD_GET to a path with backticks in
+// them; to verify the path caching of un-escaped components is correctly reset
+// between calls.
+TEST_P(McdTestappTest, MB_30278_SubdocBacktickLookup) {
+    // Test DICT_ADD where the element key contains a literal backtick.
+    store_object("doc", "{}", /*JSON*/ true, /*compress*/ false);
+    // Add a key with literal backtick (which we escape by passing
+    // double-backtick)
+    EXPECT_SD_OK(BinprotSubdocCommand(
+            PROTOCOL_BINARY_CMD_SUBDOC_DICT_ADD, "doc", "key``", "\"value\""));
+    EXPECT_SD_GET("doc", "key``", "\"value\"");
+    validate_object("doc", R"({"key`":"value"})");
+}
+
+// MB-30278: Perform two DICT_ADD calls to paths with backticks in them;
+// to verify the path caching of un-escaped components is correctly reset
+// between calls.
+TEST_P(McdTestappTest, MB_30278_SubdocBacktickDictAdd) {
+    store_object("doc", "{}", /*JSON*/ true, /*compress*/ false);
+    EXPECT_SD_OK(BinprotSubdocCommand(
+            PROTOCOL_BINARY_CMD_SUBDOC_DICT_ADD, "doc", "key``", "\"value\""));
+    EXPECT_SD_OK(BinprotSubdocCommand(PROTOCOL_BINARY_CMD_SUBDOC_DICT_ADD,
+                                      "doc",
+                                      "key2``",
+                                      "\"value2\""));
+    validate_object("doc", R"({"key`":"value","key2`":"value2"})");
+}
+
 // Tests how a single worker handles multiple "concurrent" connections
 // performing operations.
 class WorkerConcurrencyTest : public TestappTest {

tests/testapp/testapp_subdoc_multipath.cc

@@ -608,3 +608,28 @@ TEST_P(McdTestappTest, SubdocMultiMutation_AddDocFlagInavlidCas) {
                               "56"});
     expect_subdoc_cmd(mutation, PROTOCOL_BINARY_RESPONSE_EINVAL, {});
 }
+
+// MB-30278: Perform a multi-mutation with two paths with backticks in them.
+TEST_P(McdTestappTest, MB_30278_SubdocBacktickMultiMutation) {
+    store_object("dict", "{}");
+
+    SubdocMultiMutationCmd mutation;
+    mutation.key = "dict";
+    mutation.specs.push_back({PROTOCOL_BINARY_CMD_SUBDOC_DICT_ADD,
+                              SUBDOC_FLAG_NONE,
+                              "key1``",
+                              "1"});
+    mutation.specs.push_back({PROTOCOL_BINARY_CMD_SUBDOC_DICT_ADD,
+                              SUBDOC_FLAG_NONE,
+                              "key2``",
+                              "2"});
+    mutation.specs.push_back({PROTOCOL_BINARY_CMD_SUBDOC_DICT_ADD,
+                              SUBDOC_FLAG_NONE,
+                              "key3``",
+                              "3"});
+    expect_subdoc_cmd(mutation, PROTOCOL_BINARY_RESPONSE_SUCCESS, {});
+
+    validate_object("dict", R"({"key1`":1,"key2`":2,"key3`":3})");
+
+    delete_object("dict");
+}