MB-31869: Remove the MockReplicationThrottle test class

Used in just one test where not really necessary. See
https://review.couchbase.org/c/kv_engine/+/134816 for details on when
the class was introduced.

This is in preparation for removing the base ReplicationThrottle class.

Change-Id: Ib58b25023662bfb9181271aa6848145d8b5955cf
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/202696
Reviewed-by: Vesko Karaganev <[email protected]>
Tested-by: Build Bot <[email protected]>
Tested-by: Paolo Cocchi <[email protected]>

Author: paolococchi

engines/ep/CMakeLists.txt

@@ -486,7 +486,6 @@ SET(MOCK_SOURCE
     tests/mock/mock_ephemeral_bucket.cc
     tests/mock/mock_ephemeral_vb.cc
     tests/mock/mock_kvstore.cc
-    tests/mock/mock_replicationthrottle.cc
     tests/mock/mock_stream.cc
     tests/mock/mock_synchronous_ep_engine.cc
     tests/mock/mock_taskable.cc

engines/ep/tests/mock/mock_ep_bucket.cc

@@ -18,17 +18,11 @@
 #include "kvstore/kvstore.h"
 #include "mock_checkpoint_manager.h"
 #include "mock_item_freq_decayer.h"
-#include "mock_replicationthrottle.h"
 #include "vbucket.h"
 #include <executor/executorpool.h>
 
 MockEPBucket::MockEPBucket(EventuallyPersistentEngine& theEngine)
     : EPBucket(theEngine) {
-    // Replace replicationThrottle with Mock to allow controlling when it
-    // pauses during tests.
-    replicationThrottle =
-            std::make_unique<::testing::NiceMock<MockReplicationThrottle>>(
-                    replicationThrottle.release());
     ON_CALL(*this, dropKey)
             .WillByDefault([this](VBucket& vb,
                                   const DiskDocKey& key,

engines/ep/tests/mock/mock_ephemeral_bucket.cc

@@ -14,17 +14,11 @@
 #include "ep_engine.h"
 #include "failover-table.h"
 #include "mock_checkpoint_manager.h"
-#include "mock_replicationthrottle.h"
 #include "vbucket.h"
 #include <executor/executorpool.h>
 
 MockEphemeralBucket::MockEphemeralBucket(EventuallyPersistentEngine& theEngine)
     : EphemeralBucket(theEngine) {
-    // Replace replicationThrottle with Mock to allow controlling when it
-    // pauses during tests.
-    replicationThrottle =
-            std::make_unique<::testing::NiceMock<MockReplicationThrottle>>(
-                    replicationThrottle.release());
 }
 
 VBucketPtr MockEphemeralBucket::makeVBucket(

engines/ep/tests/mock/mock_replicationthrottle.cc

@@ -20,7 +20,6 @@
 #include "mock_dcp_conn_map.h"
 #include "mock_ep_bucket.h"
 #include "mock_ephemeral_bucket.h"
-#include "mock_replicationthrottle.h"
 #include "objectregistry.h"
 #include <executor/executorpool.h>
 #include <fmt/format.h>
@@ -276,8 +275,3 @@ DocKey SynchronousEPEngine::public_makeDocKey(CookieIface& cookie,
             reinterpret_cast<const uint8_t*>(key.data()), key.size()};
     return makeDocKey(cookie, buf);
 }
-
-MockReplicationThrottle& SynchronousEPEngine::getMockReplicationThrottle() {
-    return dynamic_cast<MockReplicationThrottle&>(
-            kvBucket->getReplicationThrottle());
-}

engines/ep/tests/mock/mock_replicationthrottle.h

@@ -19,7 +19,6 @@
 
 #include <memory>
 
-struct MockReplicationThrottle;
 class SynchronousEPEngine;
 
 using SynchronousEPEngineUniquePtr =
@@ -115,7 +114,6 @@ class SynchronousEPEngine : public EventuallyPersistentEngine {
     using EventuallyPersistentEngine::doCollectionStats;
     using EventuallyPersistentEngine::doConnAggStats;
     using EventuallyPersistentEngine::doEngineStats;
-    MockReplicationThrottle& getMockReplicationThrottle();
 
 private:
     std::unique_ptr<QuotaSharingManager> quotaSharingManager;

engines/ep/tests/mock/mock_synchronous_ep_engine.cc

@@ -26,14 +26,14 @@
 #include "durability/passive_durability_monitor.h"
 #include "ep_bucket.h"
 #include "kvstore/kvstore.h"
+#include "replicationthrottle.h"
 #include "test_helpers.h"
 #include "vbucket_state.h"
 #include "vbucket_utils.h"
 
 #include "../mock/mock_checkpoint_manager.h"
 #include "../mock/mock_dcp_consumer.h"
 #include "../mock/mock_dcp_producer.h"
-#include "../mock/mock_replicationthrottle.h"
 #include "../mock/mock_stream.h"
 #include "../mock/mock_synchronous_ep_engine.h"
 
@@ -4379,14 +4379,6 @@ TEST_P(DurabilityPassiveStreamTest,
                             Requirements(Level::Majority, Timeout::Infinity()));
     prepare->setBySeqno(prepareSeqno);
 
-    // We *don't* want the replication throttle to kick in before we attempt
-    // to process the prepare, so configure the MockReplicationThrottle to
-    // just return "Process" when called during the messageReceived call
-    // below.
-    using namespace ::testing;
-    EXPECT_CALL(engine->getMockReplicationThrottle(), getStatus())
-            .WillOnce(Return(ReplicationThrottle::Status::Process));
-
     // Message received by stream. Too large for current mem_used so should
     // be buffered and return TMPFAIL
     EXPECT_EQ(cb::engine_errc::temporary_failure,