Refactor: Move limited_concurrency_task to executor

This allows it to be used by other parties than ep-engine

Change-Id: I9d159e07ca635d9af2e636d3478ae0140654addc
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/190163
Tested-by: Trond Norbye <[email protected]>
Reviewed-by: Jim Walker <[email protected]>

Author: trondn

engines/ep/CMakeLists.txt

@@ -378,7 +378,6 @@ ADD_LIBRARY(ep_objs OBJECT
             src/kv_bucket.cc
             src/kvshard.cc
             src/learning_age_and_mfu_based_eviction.cc
-        src/limited_concurrency_task.cc
             src/memory_tracker.cc
             src/mutation_log.cc
             src/mutation_log_entry.cc

engines/ep/src/tasks.h

@@ -13,10 +13,8 @@
 
 #include "kvstore/kvstore.h"
 #include <executor/globaltask.h>
+#include <executor/limited_concurrency_task.h>
 #include <memcached/storeddockey.h>
-
-#include "limited_concurrency_task.h"
-
 #include <array>
 #include <chrono>
 #include <optional>

engines/ep/tests/module_tests/task_concurrency_test.cc

@@ -11,9 +11,8 @@
 
 #include "task_concurrency_test.h"
 
-#include "limited_concurrency_task.h"
-
 #include "../mock/mock_synchronous_ep_engine.h"
+#include <executor/limited_concurrency_task.h>
 #include <platform/awaitable_semaphore.h>
 #include <platform/semaphore_guard.h>
 

executor/CMakeLists.txt

@@ -12,6 +12,8 @@ add_library(mcd_executor STATIC
             futurequeue.h
             globaltask.cc
             globaltask.h
+            limited_concurrency_task.cc
+            limited_concurrency_task.h
             mock_executor_pool.cc
             mock_executor_pool.h
             notifiable_task.cc

engines/ep/src/limited_concurrency_task.cc renamed to executor/limited_concurrency_task.cc

@@ -43,6 +43,25 @@
  */
 class LimitedConcurrencyTask : public cb::Waiter, public NotifiableTask {
 public:
+    /**
+     * Construct a task which will be concurrency limited by the provided
+     * semaphore.
+     *
+     * @param t The taskable owning the task
+     * @param id task id
+     * @param semaphore semphore from which a token must be acquired before the
+     *                  task can run
+     * @param completeBeforeShutdown should the task be required to complete
+     *                               before shutdown
+     */
+    LimitedConcurrencyTask(Taskable& t,
+                           TaskId id,
+                           cb::AwaitableSemaphore& semaphore,
+                           bool completeBeforeShutdown)
+        : NotifiableTask(t, id, 0, completeBeforeShutdown),
+          semaphore(semaphore) {
+    }
+
     /**
      * Construct a task which will be concurrency limited by the provided
      * semaphore.