MB-41857: Rename OpenResult to OpenForWriteResult

Change-Id: I63755c6667cf662c993d3a5f7d3a67da7289648c
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/137784
Tested-by: Build Bot <[email protected]>
Reviewed-by: Dave Rigby <[email protected]>

Author: BenHuddleston

engines/ep/src/couch-kvstore/couch-kvstore.cc

@@ -2048,7 +2048,7 @@ CouchKVStore::OpenForReadResult CouchKVStore::openDbForRead(
     return {COUCHSTORE_SUCCESS, std::move(handle)};
 }
 
-CouchKVStore::OpenResult CouchKVStore::openDbForWrite(Vbid vbucketId) {
+CouchKVStore::OpenForWriteResult CouchKVStore::openDbForWrite(Vbid vbucketId) {
     // MB-27963: obtain read access whilst we open the file, updateDbFileMap
     // serialises on this mutex so we can be sure the fileRev we read should
     // still be a valid file once we hit sys_open

engines/ep/src/couch-kvstore/couch-kvstore.h

@@ -567,7 +567,7 @@ class CouchKVStore : public KVStore
      * is a locked instance of the DbHolder (for exclusive use by the caller).
      * If the open failed then status contains the reason, and `db` is empty.
      */
-    struct OpenResult {
+    struct OpenForWriteResult {
         couchstore_error_t status;
         CouchKVStoreFileCache::CacheMap::mapped_type::LockedPtr db;
 
@@ -576,23 +576,23 @@ class CouchKVStore : public KVStore
         // valid
         uint64_t fileRev;
 
-        // Should the Db be closed when OpenResult is destroyed
+        // Should the Db be closed when OpenForWriteResult is destroyed
         // (i.e DbHolder unlocked)?
         // Typically used for testing so every call to openDbForWrite() results
         // in an explicit couchstore_open / close pair.
         bool closeOnUnlock = false;
 
-        ~OpenResult() {
+        ~OpenForWriteResult() {
             if (closeOnUnlock) {
                 db->close();
             }
         }
         // Declaring the dtor disables auto-generation of the various ctors,
         // so need to explicitly re-enable move.
-        OpenResult(OpenResult&&) = default;
+        OpenForWriteResult(OpenForWriteResult&&) = default;
     };
 
-    OpenResult openDbForWrite(Vbid vbucketId);
+    OpenForWriteResult openDbForWrite(Vbid vbucketId);
 
     couchstore_error_t openSpecificDB(Vbid vbucketId,
                                       uint64_t rev,