MB-31869: Remove duplicate code in TestBucketImpl::set<param> functions

And introduce the new ::setParam() API that can be used to set any
dynamic configuration param.

Change-Id: I5e2402f10368f623e9ea5d39db5d6862e722a54e
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/203486
Reviewed-by: Jim Walker <[email protected]>
Tested-by: Build Bot <[email protected]>

Author: paolococchi

tests/testapp/testapp_environment.cc

@@ -63,51 +63,49 @@ void TestBucketImpl::createEwbBucket(const std::string& name,
     conn.createBucket(name, cfg, BucketType::EWouldBlock);
 }
 
-// Both memcache and ep-engine buckets support set_param for xattr on/off
+// Both memcached and ep-engine buckets support set_param for xattr on/off
 void TestBucketImpl::setXattrEnabled(MemcachedConnection& conn,
                                      const std::string& bucketName,
                                      bool value) {
-    conn.executeInBucket(bucketName, [&](auto& connection) {
-        // Encode a set_flush_param (like cbepctl)
-        BinprotGenericCommand cmd{cb::mcbp::ClientOpcode::SetParam,
-                                  "xattr_enabled",
-                                  value ? "true" : "false"};
-        cmd.setExtrasValue<uint32_t>(htonl(static_cast<uint32_t>(
-                cb::mcbp::request::SetParamPayload::Type::Flush)));
-
-        const auto resp = connection.execute(cmd);
-        ASSERT_EQ(cb::mcbp::Status::Success, resp.getStatus());
-    });
+    setParam(conn,
+             bucketName,
+             "xattr_enabled",
+             value ? "true" : "false",
+             cb::mcbp::request::SetParamPayload::Type::Flush);
 }
 
 void TestBucketImpl::setCompressionMode(MemcachedConnection& conn,
                                         const std::string& bucketName,
                                         const std::string& value) {
-    conn.executeInBucket(bucketName, [&](auto& connection) {
-        // Encode a set_flush_param (like cbepctl)
-        BinprotGenericCommand cmd{
-                cb::mcbp::ClientOpcode::SetParam, "compression_mode", value};
-        cmd.setExtrasValue<uint32_t>(htonl(static_cast<uint32_t>(
-                cb::mcbp::request::SetParamPayload::Type::Flush)));
-
-        const auto resp = connection.execute(cmd);
-        ASSERT_EQ(cb::mcbp::Status::Success, resp.getStatus());
-    });
+    setParam(conn,
+             bucketName,
+             "compression_mode",
+             value,
+             cb::mcbp::request::SetParamPayload::Type::Flush);
 }
 
 void TestBucketImpl::setMinCompressionRatio(MemcachedConnection& conn,
                                             const std::string& bucketName,
                                             const std::string& value) {
+    setParam(conn,
+             bucketName,
+             "min_compression_ratio",
+             value,
+             cb::mcbp::request::SetParamPayload::Type::Flush);
+}
+
+void TestBucketImpl::setParam(
+        MemcachedConnection& conn,
+        const std::string& bucketName,
+        const std::string& paramName,
+        const std::string& paramValue,
+        cb::mcbp::request::SetParamPayload::Type paramType) {
     conn.executeInBucket(bucketName, [&](auto& connection) {
-        // Encode a set_flush_param (like cbepctl)
-        BinprotGenericCommand cmd{cb::mcbp::ClientOpcode::SetParam,
-                                  "min_compression_ratio",
-                                  value};
-        cmd.setExtrasValue<uint32_t>(htonl(static_cast<uint32_t>(
-                cb::mcbp::request::SetParamPayload::Type::Flush)));
-
-        const auto resp = connection.execute(cmd);
-        ASSERT_EQ(cb::mcbp::Status::Success, resp.getStatus());
+        BinprotGenericCommand cmd{
+                cb::mcbp::ClientOpcode::SetParam, paramName, paramValue};
+        cmd.setExtrasValue<uint32_t>(htonl(static_cast<uint32_t>(paramType)));
+        ASSERT_EQ(cb::mcbp::Status::Success,
+                  connection.execute(cmd).getStatus());
     });
 }
 

tests/testapp/testapp_environment.h

@@ -10,6 +10,7 @@
  */
 #pragma once
 
+#include <memcached/protocol_binary.h>
 #include <nlohmann/json_fwd.hpp>
 #include <functional>
 #include <string>
@@ -98,6 +99,22 @@ class TestBucketImpl {
                                 const std::string& bucketName,
                                 const std::string& value);
 
+    /**
+     * Set a configuration param for the named bucket.
+     *
+     * @param conn The connection to use (must have admin privileges)
+     * @param bucketName The name of the bucket to modify
+     * @param paramName
+     * @param paramValue
+     * @param paramType See cb::mcbp::request::SetParamPayload::Type for
+     * details.
+     */
+    void setParam(MemcachedConnection& conn,
+                  const std::string& bucketName,
+                  const std::string& paramName,
+                  const std::string& paramValue,
+                  cb::mcbp::request::SetParamPayload::Type paramType);
+
 protected:
     static void createEwbBucket(const std::string& name,
                                 const std::string& plugin,