MB-16181: Adjust seqno range test in isLogicallyDeleted

A create collection system event was incorrectly flagged as logically
deleted because the seqno range check incorrectly used 'less-or-equal'.

Change-Id: I358ce13608edf1ea933bfb5d3e27d2027b39346e
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/133729
Tested-by: Build Bot <[email protected]>
Reviewed-by: Dave Rigby <[email protected]>

Author: jimwwalker

engines/ep/src/collections/vbucket_manifest.cc

@@ -542,7 +542,7 @@ bool Manifest::isLogicallyDeleted(const container::const_iterator entry,
 
     // seqno >= 0 (so temp items etc... are ok) AND the seqno is below the
     // collection start (start is set on creation and moves with flush)
-    return seqno >= 0 && seqno <= entry->second.getStartSeqno();
+    return seqno >= 0 && seqno < entry->second.getStartSeqno();
 }
 
 void Manifest::processExpiryTime(const container::const_iterator entry,

engines/ep/tests/module_tests/collections/vbucket_manifest_test.cc

@@ -796,6 +796,17 @@ TEST_F(VBucketManifestTest, check_applyChanges) {
     EXPECT_EQ(2, manifest.getActiveManifest().size());
 }
 
+TEST_F(VBucketManifestTest, isLogicallyDeleted) {
+    // This test creates the vegetable collection at seqno 1, it is not
+    // logically deleted
+    EXPECT_TRUE(manifest.update(cm));
+    auto item = SystemEventFactory::makeCollectionEvent(
+            CollectionEntry::vegetable, {}, {});
+    auto sno = manifest.getActiveVB().getHighSeqno();
+    EXPECT_FALSE(
+            manifest.active.lock().isLogicallyDeleted(item->getKey(), sno));
+}
+
 class VBucketManifestCachingReadHandle : public VBucketManifestTest {};
 
 TEST_F(VBucketManifestCachingReadHandle, basic) {
@@ -843,5 +854,6 @@ TEST_F(VBucketManifestCachingReadHandle, deleted_default) {
     EXPECT_TRUE(manifest.update(cm.remove(CollectionEntry::defaultC)));
     StoredDocKey key{"fruit:v1", CollectionEntry::defaultC};
     auto rh = manifest.active.lock(key);
-    EXPECT_TRUE(rh.isLogicallyDeleted(0));
+    // Real items begin at seqno 1
+    EXPECT_TRUE(rh.isLogicallyDeleted(1 /*seqno*/));
 }