MB-28685: Expand ep_testsuite value_eviction tests to passive mode

As part of expanding the different ep_testsuite tests to work in
different compression modes, this change will support the different
ep_testsuite value_eviction tests to passive compression mode

Change-Id: I35960c4a36b1c323764c43be87c561d843831a6c
Reviewed-on: http://review.couchbase.org/95449
Well-Formed: Build Bot <[email protected]>
Tested-by: Build Bot <[email protected]>
Reviewed-by: Dave Rigby <[email protected]>

Author: Sriram Ganesan

engines/ep/CMakeLists.txt

@@ -441,8 +441,8 @@ if (COUCHBASE_KV_BUILD_UNIT_TESTS)
                 tests/mock/mock_dcp.cc)
     SET_TARGET_PROPERTIES(ep_testsuite PROPERTIES PREFIX "")
     TARGET_LINK_LIBRARIES(ep_testsuite engine_utilities mcd_util
-                          ${EP_STORAGE_LIBS} dirutils JSON_checker platform
-                          xattr
+                          ${EP_STORAGE_LIBS} cbcompress dirutils JSON_checker
+                          platform xattr
                           ${LIBEVENT_LIBRARIES})
     ADD_DEPENDENCIES(ep_testsuite engine_testapp)
 
@@ -455,7 +455,8 @@ if (COUCHBASE_KV_BUILD_UNIT_TESTS)
                 )
     SET_TARGET_PROPERTIES(ep_testsuite_basic PROPERTIES PREFIX "")
     TARGET_LINK_LIBRARIES(ep_testsuite_basic engine_utilities JSON_checker dirutils
-                          platform ${LIBEVENT_LIBRARIES} ${SNAPPY_LIBRARIES})
+                          cbcompress platform ${LIBEVENT_LIBRARIES}
+                          ${SNAPPY_LIBRARIES})
     ADD_DEPENDENCIES(ep_testsuite engine_testapp)
 
     ADD_LIBRARY(ep_testsuite_dcp SHARED
@@ -475,7 +476,9 @@ if (COUCHBASE_KV_BUILD_UNIT_TESTS)
                 tests/ep_test_apis.cc
                 src/ext_meta_parser.cc)
     SET_TARGET_PROPERTIES(ep_testsuite_checkpoint PROPERTIES PREFIX "")
-    TARGET_LINK_LIBRARIES(ep_testsuite_checkpoint engine_utilities JSON_checker dirutils platform ${LIBEVENT_LIBRARIES} ${SNAPPY_LIBRARIES})
+    TARGET_LINK_LIBRARIES(ep_testsuite_checkpoint engine_utilities JSON_checker
+                          cbcompress dirutils platform ${LIBEVENT_LIBRARIES}
+                          ${SNAPPY_LIBRARIES})
     ADD_DEPENDENCIES(ep_testsuite_checkpoint engine_testapp)
 
     ADD_LIBRARY(ep_testsuite_xdcr SHARED
@@ -495,7 +498,7 @@ if (COUCHBASE_KV_BUILD_UNIT_TESTS)
                 tests/ep_test_apis.cc
                 tests/mock/mock_dcp.cc)
     SET_TARGET_PROPERTIES(ep_perfsuite PROPERTIES PREFIX "")
-    TARGET_LINK_LIBRARIES(ep_perfsuite engine_utilities dirutils platform)
+    TARGET_LINK_LIBRARIES(ep_perfsuite engine_utilities cbcompress dirutils platform)
     ADD_DEPENDENCIES(ep_perfsuite engine_testapp)
 
     #ADD_CUSTOM_COMMAND(OUTPUT
@@ -584,11 +587,14 @@ if (COUCHBASE_KV_BUILD_UNIT_TESTS)
             ${Memcached_BINARY_DIR}/engine_testapp
             -E $<TARGET_FILE:ep>
             -T $<TARGET_FILE:${name}>)
-        ADD_TEST(NAME ${name}.value_eviction
-                 COMMAND ${_cmdline} -v -e "dbname=./${name}.value_eviction.db")
+        ADD_TEST(NAME ${name}.value_eviction.comp_off
+                 COMMAND ${_cmdline} -v -e "compression_mode=off$<SEMICOLON>dbname=./${name}.value_eviction.comp_off.db")
+        ADD_TEST(NAME ${name}.value_eviction.comp_passive
+                 COMMAND ${_cmdline} -v -e "compression_mode=passive$<SEMICOLON>dbname=./${name}.value_eviction.comp_passive.db")
         ADD_TEST(NAME ${name}.full_eviction
                  COMMAND ${_cmdline} -v -e "item_eviction_policy=full_eviction$<SEMICOLON>dbname=./${name}.full_eviction.db")
-        SET_TESTS_PROPERTIES(${name}.value_eviction PROPERTIES TIMEOUT ${timeout})
+        SET_TESTS_PROPERTIES(${name}.value_eviction.comp_off PROPERTIES TIMEOUT ${timeout})
+        SET_TESTS_PROPERTIES(${name}.value_eviction.comp_passive PROPERTIES TIMEOUT ${timeout})
         SET_TESTS_PROPERTIES(${name}.full_eviction PROPERTIES TIMEOUT ${timeout})
 
         IF (NOT arg_SKIP_EPHEMERAL)

engines/ep/tests/ep_testsuite.cc

@@ -6905,6 +6905,12 @@ static enum test_result test_mb19687_fixed(ENGINE_HANDLE* h,
                                            "ep_warmup_thread"});
     }
 
+    if (isCompressionEnabled(h, h1)) {
+        auto& vb0_hash_stats = statsKeys.at("hash");
+        vb0_hash_stats.insert(vb0_hash_stats.end(),
+                              {"vb_0:mem_size_uncompressed"});
+    }
+
     if (isPersistentBucket(h, h1)) {
         // Add data_size and file_size stats to toplevel group.
         auto& eng_stats = statsKeys.at("");

engines/ep/tests/ep_testsuite_common.cc

@@ -26,6 +26,7 @@
 #include <sys/stat.h>
 
 #include <platform/cb_malloc.h>
+#include <platform/compress.h>
 #include <platform/dirutils.h>
 
 const char *dbname_env = NULL;
@@ -448,8 +449,36 @@ void check_key_value(ENGINE_HANDLE *h, ENGINE_HANDLE_V1 *h1,
                      uint16_t vbucket) {
     item_info info;
     check(get_item_info(h, h1, &info, key, vbucket), "checking key and value");
-    checkeq(vlen, info.value[0].iov_len, "Value length mismatch");
-    check(memcmp(info.value[0].iov_base, val, vlen) == 0, "Data mismatch");
+
+    cb::const_char_buffer payload;
+    cb::compression::Buffer inflated;
+    if (isCompressionEnabled(h, h1) &&
+        (info.datatype & PROTOCOL_BINARY_DATATYPE_SNAPPY)) {
+        cb::compression::inflate(cb::compression::Algorithm::Snappy,
+                                 {static_cast<const char *>(info.value[0].iov_base),
+                                  info.value[0].iov_len},
+                                 inflated);
+        payload = inflated;
+    } else {
+        payload = {static_cast<const char *>(info.value[0].iov_base),
+                                             info.value[0].iov_len};
+    }
+
+    checkeq(vlen, payload.size(), "Value length mismatch");
+    check(memcmp(payload.data(), val, vlen) == 0, "Data mismatch");
+}
+
+bool isCompressionEnabled(ENGINE_HANDLE* h, ENGINE_HANDLE_V1* h1) {
+    return (isPassiveCompressionEnabled(h, h1) ||
+            isActiveCompressionEnabled(h, h1));
+}
+
+bool isActiveCompressionEnabled(ENGINE_HANDLE* h, ENGINE_HANDLE_V1* h1) {
+    return get_str_stat(h, h1, "ep_compression_mode") == "active";
+}
+
+bool isPassiveCompressionEnabled(ENGINE_HANDLE* h, ENGINE_HANDLE_V1* h1) {
+    return get_str_stat(h, h1, "ep_compression_mode") == "passive";
 }
 
 bool isWarmupEnabled(ENGINE_HANDLE* h, ENGINE_HANDLE_V1* h1) {

engines/ep/tests/ep_testsuite_common.h

@@ -278,6 +278,15 @@ void check_key_value(ENGINE_HANDLE *h, ENGINE_HANDLE_V1 *h1,
 
 std::string get_dbname(const char* test_cfg);
 
+// Returns true if Compression is enabled for the given engine.
+bool isCompressionEnabled(ENGINE_HANDLE* h, ENGINE_HANDLE_V1* h1);
+
+// Returns true if passive compression is enabled for the given engine.
+bool isPassiveCompressionEnabled(ENGINE_HANDLE* h, ENGINE_HANDLE_V1* h1);
+
+// Returns true if active compression is enabled for the given engine.
+bool isActiveCompressionEnabled(ENGINE_HANDLE* h, ENGINE_HANDLE_V1* h1);
+
 // Returns true if Warmup is enabled for the given engine.
 bool isWarmupEnabled(ENGINE_HANDLE* h, ENGINE_HANDLE_V1* h1);