MB-41857: Rename OpenForReadResult to OpenResult

In a future patch I want to use Open(ForRead)Result in a non-read use
case.

Change-Id: I8e524b11355247863a99d6880dd307a3475dd3b5
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/137785
Tested-by: Build Bot <[email protected]>
Reviewed-by: Dave Rigby <[email protected]>

Author: BenHuddleston

engines/ep/src/couch-kvstore/couch-kvstore.cc

@@ -2000,8 +2000,8 @@ couchstore_error_t CouchKVStore::openDB(Vbid vbucketId,
     return openSpecificDB(vbucketId, fileRev, db, options, ops);
 }
 
-CouchKVStore::OpenForReadResult CouchKVStore::openDbForRead(
-        Vbid vbucketId, FileOpsInterface* ops) {
+CouchKVStore::OpenResult CouchKVStore::openDbForRead(Vbid vbucketId,
+                                                     FileOpsInterface* ops) {
     // MB-27963: obtain read access whilst we open the file, updateDbFileMap
     // serialises on this mutex so we can be sure the fileRev we read should
     // still be a valid file once we hit sys_open

engines/ep/src/couch-kvstore/couch-kvstore.h

@@ -547,19 +547,18 @@ class CouchKVStore : public KVStore
      * reason and fileHandle should have a valid revision value but the
      * underlying Db shouldn't be used.
      */
-    struct OpenForReadResult {
+    struct OpenResult {
         couchstore_error_t status;
         std::unique_ptr<CouchKVFileHandle> fileHandle;
 
-        ~OpenForReadResult() = default;
+        ~OpenResult() = default;
 
         // Declaring the dtor disables auto-generation of the various ctors,
         // so need to explicitly re-enable move.
-        OpenForReadResult(OpenForReadResult&&) = default;
+        OpenResult(OpenResult&&) = default;
     };
 
-    OpenForReadResult openDbForRead(Vbid vbucketId,
-                                    FileOpsInterface* ops = nullptr);
+    OpenResult openDbForRead(Vbid vbucketId, FileOpsInterface* ops = nullptr);
 
     /**
      * The result of calling openDbForWrite.

engines/ep/tests/mock/mock_couch_kvstore.h

@@ -117,8 +117,8 @@ class MockCouchKVStore : public CouchKVStore {
         return std::make_unique<MockCouchKVStore>(configuration, dbFileRevMap);
     }
 
-    OpenForReadResult public_openDbForRead(Vbid vbid,
-                                           FileOpsInterface* ops = nullptr) {
+    OpenResult public_openDbForRead(Vbid vbid,
+                                    FileOpsInterface* ops = nullptr) {
         return openDbForRead(vbid, ops);
     }