MB-58654: Return bucket name as the key stat name

And disable validation for that stat

Change-Id: Ic84cffb7e543df51f41b8b8a7d15b2fef23175f2
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/197180
Tested-by: Ben Huddleston <[email protected]>
Reviewed-by: Ben Huddleston <[email protected]>

Author: trondn

daemon/protocol/mcbp/stats_context.cc

@@ -245,9 +245,7 @@ static cb::engine_errc stat_bucket_details_executor(const std::string& arg,
         Bucket& bucket = BucketManager::instance().at(ii);
         auto json = bucket.to_json();
         if (!json.empty() && json["name"] == arg) {
-            const auto stats_str = json.dump();
-            append_stats(
-                    fmt::format("bucket details:{}", arg), stats_str, cookie);
+            append_stats(arg, json.dump(), cookie);
             return cb::engine_errc::success;
         }
     }

tests/testapp/testapp_stats.cc

@@ -505,11 +505,12 @@ TEST_P(StatsTest, TestBucketDetailsSingleBucket) {
     nlohmann::json json;
     size_t ncallback = 0;
 
+    adminConnection->setUserValidateReceivedFrameCallback({});
     adminConnection->stats(
             [this, &json, &ncallback](const auto& k, const auto& v) {
                 ++ncallback;
                 if (!k.empty()) {
-                    ASSERT_EQ(fmt::format("bucket details:{}", bucketName), k);
+                    ASSERT_EQ(bucketName, k);
                     ASSERT_FALSE(v.empty());
                     json = nlohmann::json::parse(v);
                 } else {