MB-58646: Disallow getting command timings for not current bucket

This was broken for a long time and mctimings selects the bucket first
hence not entering the erroneous code path.

Change-Id: Id470619de431d429655e4940c42a5999b09d6a42
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/197182
Reviewed-by: Trond Norbye <[email protected]>
Tested-by: Build Bot <[email protected]>

Author: pavlosg

daemon/protocol/mcbp/get_cmd_timer_executor.cc

@@ -174,27 +174,9 @@ std::pair<cb::engine_errc, std::string> get_cmd_timer(Cookie& cookie) {
         return std::make_pair(bt.first, std::string{});
     }
 
-    // The user specified a bucket... let's locate the bucket
-    std::pair<cb::engine_errc, Hdr1sfMicroSecHistogram> ret;
-
-    for (auto& b : all_buckets) {
-        ret = maybe_get_timings(cookie, b, opcode, bucket);
-        if (ret.first != cb::engine_errc::no_such_key &&
-            ret.first != cb::engine_errc::success) {
-            break;
-        }
-    }
-
-    if (ret.first == cb::engine_errc::success) {
-        return std::make_pair(cb::engine_errc::success, ret.second.to_string());
-    }
-
-    if (ret.first == cb::engine_errc::no_such_key) {
-        // Don't tell the user that the bucket doesn't exist
-        ret.first = cb::engine_errc::no_access;
-    }
-
-    return std::make_pair(ret.first, std::string{});
+    // We removed support for getting command timings for not the current bucket
+    // as it was broken and unused
+    return std::make_pair(cb::engine_errc::not_supported, std::string{});
 }
 
 void get_cmd_timer_executor(Cookie& cookie) {

tests/testapp/testapp_cmd_timers.cc

@@ -126,6 +126,19 @@ TEST_P(CmdTimerTest, CurrentBucket) {
     });
 }
 
+/**
+ * We removed support for getting command timings for not the current bucket
+ * as it was broken and unused
+ */
+TEST_P(CmdTimerTest, NotCurrentBucket) {
+    adminConnection->executeInBucket(bucketName, [this](auto& c) {
+        const auto response = c.execute(BinprotGetCmdTimerCommand{
+                "rbac_test", cb::mcbp::ClientOpcode::Scrub});
+        EXPECT_FALSE(response.isSuccess());
+        EXPECT_EQ(cb::mcbp::Status::NotSupported, response.getStatus());
+    });
+}
+
 /**
  * We should get no access for unknown buckets
  */