MB-51458 check if consumer truncates names when constructing

...connection name on producer, so wait_for_data_move doesn't
use trimmed name for the connection created by node that does
not trim names

Change-Id: Ic57ae3661f774b9556d1434e6ca305b619277ae2
Reviewed-on: https://review.couchbase.org/c/ns_server/+/172672
Well-Formed: Restriction Checker
Well-Formed: Build Bot <[email protected]>
Reviewed-by: Timofey Barmin <[email protected]>
Tested-by: Artem Stemkovski <[email protected]>

Author: vzasade

src/dcp_replicator.erl

@@ -251,7 +251,7 @@ get_connection_name(ConsumerNode, ProducerNode, Bucket) ->
         true ->
             CName;
         false ->
-            case should_truncate_name(ProducerNode) of
+            case should_truncate_name(ConsumerNode, ProducerNode) of
                 true ->
                     get_truncated_connection_name(
                       CName, ConsumerNode, ProducerNode, Bucket);
@@ -272,15 +272,24 @@ get_truncated_connection_name(LongName, ConsumerNode, ProducerNode, Bucket) ->
     true = length(CName) =< ?MAX_DCP_CONNECTION_NAME,
     CName.
 
-should_truncate_name(ProducerNode) ->
-    case cluster_compat_mode:is_cluster_71() of
+node_supports_truncated_names(Node) ->
+    case Node == misc:this_node() of
         true ->
             true;
         false ->
-            Quirks = rebalance_quirks:get_quirks([ProducerNode], long_names),
+            Quirks = rebalance_quirks:get_quirks([Node], long_names),
             not rebalance_quirks:is_enabled(
                   dont_truncate_long_names,
-                  rebalance_quirks:get_node_quirks(ProducerNode, Quirks))
+                  rebalance_quirks:get_node_quirks(Node, Quirks))
+    end.
+
+should_truncate_name(ConsumerNode, ProducerNode) ->
+    case cluster_compat_mode:is_cluster_71() of
+        true ->
+            true;
+        false ->
+            lists:all(fun node_supports_truncated_names/1,
+                      [ConsumerNode, ProducerNode])
     end.
 
 trim_common_prefix(Consumer, Producer) ->
@@ -383,12 +392,14 @@ get_connection_name_test_() ->
      fun () ->
              meck:new(cluster_compat_mode, [passthrough]),
              meck:new(rebalance_quirks, [passthrough]),
+             meck:new(misc, [passthrough]),
              meck:expect(cluster_compat_mode, is_cluster_71,
                          fun () -> true end)
      end,
      fun (_) ->
              meck:unload(cluster_compat_mode),
-             meck:unload(rebalance_quirks)
+             meck:unload(rebalance_quirks),
+             meck:unload(misc)
      end,
      [{"Connection name fits into the maximum allowed",
        fun () ->
@@ -413,6 +424,7 @@ get_connection_name_test_() ->
                            fun () -> false end),
                meck:expect(rebalance_quirks, get_quirks,
                            fun (_, long_names) -> [{ProducerNode, []}] end),
+               meck:expect(misc, this_node, fun () -> ConsumerNode end),
                ?assertEqual(
                   TrimmedName,
                   get_connection_name(ConsumerNode, ProducerNode,
@@ -427,6 +439,7 @@ get_connection_name_test_() ->
                            fun (_, long_names) ->
                                    [{ProducerNode, [dont_truncate_long_names]}]
                            end),
+               meck:expect(misc, this_node, fun () -> ConsumerNode end),
                Conn = get_connection_name(ConsumerNode, ProducerNode,
                                           VeryLongBucket),
                ?assertEqual(

src/misc.erl

@@ -339,6 +339,10 @@ position(E, [_|List], N) -> position(E, List, N+1).
 msecs_to_usecs(MilliSec) ->
     MilliSec * 1000.
 
+%% just because we need to mock node() sometimes
+this_node() ->
+    node().
+
 % Returns just the node name string that's before the '@' char.
 % For example, returns "test" instead of "[email protected]".
 %