Skip to content

Commit 29da984

Browse files
committed
MB-63683 Remove unneeded OnPremBucketTestSet
The OnPremBucketTestSet is removed as it is redundant with other tests. Change-Id: I7fb323f8fb171d96f39aa734620a77e042b20c09 Reviewed-on: https://review.couchbase.org/c/ns_server/+/216850 Reviewed-by: Steve Watanabe <[email protected]> Well-Formed: Build Bot <[email protected]> Tested-by: Steve Watanabe <[email protected]>
1 parent 6d73a36 commit 29da984

File tree

1 file changed

+5
-59
lines changed

1 file changed

+5
-59
lines changed

cluster_tests/testsets/bucket_test.py

Lines changed: 5 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
was_auto_compaction_change_made to parse the values from the response to a bucket
3333
GET request, in order to verify that the new parameter value is present
3434
- Add a test function to the appropriate test class (BasicBucketTestSet,
35-
OnPremBucketTestSet, MultiNodeBucketTestSet, or ServerlessBucketTestSet).
35+
MultiNodeBucketTestSet, or ServerlessBucketTestSet).
3636
This should contain a call of self.test_param("param", **main_params) with
3737
main_params defining which tests are to be performed
3838
Note:
@@ -2311,64 +2311,6 @@ def num_vbuckets_test(self):
23112311
just_validate=[True, False],
23122312
is_creation=[True, False])
23132313

2314-
2315-
class OnPremBucketTestSet(BucketTestSetBase):
2316-
2317-
@staticmethod
2318-
def requirements():
2319-
return testlib.ClusterRequirements(edition="Enterprise", buckets=[])
2320-
2321-
def bucket_type_test(self):
2322-
self.test_param("bucketType",
2323-
bucket_type=["memcached"],
2324-
storage_backend=["couchstore"],
2325-
auto_compaction_defined=[None],
2326-
rank=[0],
2327-
conflict_resolution_type=["seqno"],
2328-
bucket_placer=[False],
2329-
allowed_time_period=[False],
2330-
just_validate=[True, False],
2331-
is_creation=[True])
2332-
2333-
def ram_quota_test(self):
2334-
self.test_param("ramQuota",
2335-
bucket_type=["memcached"],
2336-
storage_backend=["couchstore"],
2337-
auto_compaction_defined=[None],
2338-
conflict_resolution_type=["seqno"],
2339-
rank=[0],
2340-
bucket_placer=[False],
2341-
allowed_time_period=[False],
2342-
just_validate=[True, False],
2343-
is_creation=[True, False])
2344-
2345-
# TOFIX: replica_index and replica_number give different errors based
2346-
# whether just_validate is True or False and also if the num_nodes is less
2347-
# than or greater than the set value.
2348-
2349-
# def replica_index_test(self):
2350-
# self.test_param("replicaIndex",
2351-
# bucket_type=["couchbase", "memcached"],
2352-
# storage_backend=["couchstore"],
2353-
# auto_compaction_defined=[None],
2354-
# conflict_resolution_type=["seqno"],
2355-
# bucket_placer=[False],
2356-
# allowed_time_period=[False],
2357-
# just_validate=[True, False],
2358-
# is_creation=[True])
2359-
2360-
# def replica_number_test(self):
2361-
# self.test_param("replicaNumber",
2362-
# bucket_type=["couchbase"],
2363-
# storage_backend=["couchstore"],
2364-
# auto_compaction_defined=[None],
2365-
# conflict_resolution_type=["seqno"],
2366-
# bucket_placer=[False],
2367-
# allowed_time_period=[False],
2368-
# just_validate=[True, False],
2369-
# is_creation=[True, False])
2370-
2371-
23722314
class MultiNodeBucketTestSet(BucketTestSetBase):
23732315

23742316
@staticmethod
@@ -2377,6 +2319,10 @@ def requirements():
23772319
balanced=True,
23782320
buckets=[])
23792321

2322+
# TOFIX: replica_number give different errors based
2323+
# whether just_validate is True or False and also if the num_nodes is less
2324+
# than or greater than the set value.
2325+
23802326
# def replica_number_test(self):
23812327
# self.test_param("replicaNumber",
23822328
# bucket_type=["couchbase"],

0 commit comments

Comments
 (0)