MB-47087 Change chars_limit default from 50K to -1

io_lib:format/3 with chars_limit has be been buggy and therefore to err
on the side of caution moving the chars_limit to -1. Essentially
reverting to the old full term logging.

Change-Id: I44597a52aacc740fcc7a8da1c5a3a34d27ef4dd7
Reviewed-on: http://review.couchbase.org/c/ns_server/+/158982
Tested-by: <[email protected]>
Reviewed-by: Meni Hillel <[email protected]>

Author: hareen-kancharla

deps/ale/src/ale_codegen.erl

@@ -13,7 +13,7 @@
 
 -include("ale.hrl").
 
--define(CHARS_LIMIT_DEFAULT, 50000).
+-define(CHARS_LIMIT_DEFAULT, -1).
 
 logger_impl(Logger) when is_atom(Logger) ->
     logger_impl(atom_to_list(Logger));

src/ns_pubsub.erl

@@ -150,14 +150,12 @@ do_subscribe_link_continue(Name, Parent, Handler) ->
                 end;
             {'EXIT', Parent, Reason} ->
                 ?log_debug("Parent process of subscription ~p "
-                           "exited with reason ~p", [{Name, Parent}, Reason],
-                                                     [{chars_limit, 1000}]),
+                           "exited with reason ~p", [{Name, Parent}, Reason]),
                 normal;
             {'EXIT', Pid, Reason} ->
                 ?log_debug("Linked process ~p of subscription ~p "
                            "died unexpectedly with reason ~p",
-                           [Pid, {Name, Parent}, Reason],
-                            [{chars_limit, 1000}]),
+                           [Pid, {Name, Parent}, Reason]),
                 {linked_process_died, Pid, Reason};
             X ->
                 ?log_error("Subscription ~p got unexpected message: ~p",