MB-61292: [cluster tests] Sort nodes when verifying services

Nodes can change order in the connected_nodes list (e.g. if we remove
and add node back). In this case the services requirement can fail
because it depends on the order of nodes in the list.
This change makes the requirement agnostic to that order.

Change-Id: I4f7db19fc51078937d82066fc08e94c4dd177eb9
Reviewed-on: https://review.couchbase.org/c/ns_server/+/223445
Well-Formed: Build Bot <[email protected]>
Tested-by: Build Bot <[email protected]>
Reviewed-by: Peter Searby <[email protected]>
Tested-by: Timofey Barmin <[email protected]>

Author: timofey-barmin

cluster_tests/testlib/node.py

@@ -36,6 +36,9 @@ def __str__(self):
     def __repr__(self):
         return self.__dict__.__repr__()
 
+    def __lt__(self, other):
+        return self.hostname() < other.hostname()
+
     def data_path(self):
         if self.data_path_cache is None:
             r = testlib.diag_eval(self, "path_config:component_path(data).")

cluster_tests/testlib/requirements.py

@@ -522,7 +522,7 @@ def __init__(self, deploy: Union[List[Service], Dict[str, List[Service]]]):
         self.connect_args = {"deploy": self.deploy}
 
     def is_met(self, cluster):
-        for i, node in enumerate(cluster.connected_nodes):
+        for i, node in enumerate(sorted(cluster.connected_nodes)):
             # We can't take information for all nodes from a single /pools/nodes
             # because we don't know which node is which
             res = get_succ(node, "/pools/nodes").json()