MB-61292: Fix ns_bucket:get_encryption

It should check if bucket exists on that node first, and only after
that it should check if encryption is enabled.
Reason: if get_encryption() returns disabled, cb_cluster_secrets
assumes that the bucket is present on that node.

Change-Id: Id3755f16ba0a67c9beecb2fc65c10b9d6132272d
Reviewed-on: https://review.couchbase.org/c/ns_server/+/215090
Reviewed-by: Navdeep S Boparai <[email protected]>
Tested-by: Build Bot <[email protected]>
Well-Formed: Build Bot <[email protected]>
Tested-by: Timofey Barmin <[email protected]>

Author: timofey-barmin

apps/ns_server/src/ns_bucket.erl

@@ -2521,14 +2521,15 @@ validate_encryption_secret(SecretId, Bucket, Snapshot) ->
 get_encryption(BucketName, Snapshot) ->
     case get_bucket(BucketName, Snapshot) of
         {ok, BucketConfig} ->
-            case proplists:get_value(encryption_secret_id, BucketConfig,
-                                     ?SECRET_ID_NOT_SET) of
-                ?SECRET_ID_NOT_SET -> {ok, disabled};
-                Id ->
-                    case lists:member(node(), get_servers(BucketConfig)) of
-                        true -> {ok, {secret, Id}};
-                        false -> {error, not_found}
-                    end
+            case lists:member(node(), get_servers(BucketConfig)) of
+                true ->
+                    case proplists:get_value(encryption_secret_id, BucketConfig,
+                                             ?SECRET_ID_NOT_SET) of
+                        ?SECRET_ID_NOT_SET -> {ok, disabled};
+                        Id -> {ok, {secret, Id}}
+                    end;
+                false ->
+                    {error, not_found}
             end;
         not_present ->
             {error, not_found}