MB-47561 remove unused send_terse_streaming_buckets knob

Change-Id: If48bc792a3556a56c86b44657f1a7a64c51174e4
Reviewed-on: http://review.couchbase.org/c/ns_server/+/158232
Well-Formed: Restriction Checker
Tested-by: Artem Stemkovski <[email protected]>
Reviewed-by: Aliaksey Artamonau <[email protected]>

Author: vzasade

src/bucket_info_cache.erl

@@ -20,8 +20,7 @@
 -include("ns_common.hrl").
 
 -export([start_link/0,
-         terse_bucket_info/1,
-         terse_bucket_info_with_local_addr/2]).
+         terse_bucket_info/1]).
 
 -export([build_node_services/0]).
 
@@ -325,12 +324,3 @@ do_build_node_services() ->
     J = {[{rev, Rev},
           {nodesExt, NEIs}] ++ Caps},
     {Rev, ejson:encode(J)}.
-
-terse_bucket_info_with_local_addr(BucketName, LocalAddr) ->
-    case terse_bucket_info(BucketName) of
-        {ok, _, Bin} ->
-            {ok, binary:replace(Bin, list_to_binary(?LOCALHOST_MARKER_STRING),
-                                list_to_binary(LocalAddr), [global])};
-        Other ->
-            Other
-    end.

src/menelaus_web_buckets.erl

@@ -480,19 +480,13 @@ handle_sasl_buckets_streaming(_PoolId, Req) ->
 
 handle_bucket_info_streaming(_PoolId, Id, Req) ->
     LocalAddr = menelaus_util:local_addr(Req),
-    SendTerse = ns_config:read_key_fast(send_terse_streaming_buckets, false),
     F = fun(_Stability, _UpdateID) ->
                 case ns_bucket:get_bucket(Id) of
                     {ok, BucketConfig} ->
-                        case SendTerse of
-                            true ->
-                                {ok, Bin} = bucket_info_cache:terse_bucket_info_with_local_addr(Id, LocalAddr),
-                                {just_write, {write, Bin}};
-                            _ ->
-                                Info = build_bucket_info(Id, BucketConfig, streaming, LocalAddr,
-                                                         may_expose_bucket_auth(Id, Req), false),
-                                {just_write, Info}
-                        end;
+                        Info = build_bucket_info(
+                                 Id, BucketConfig, streaming, LocalAddr,
+                                 may_expose_bucket_auth(Id, Req), false),
+                        {just_write, Info};
                     not_present ->
                         exit(normal)
                 end