MB-47499: enable form submission when form is ready

when all initial values are set and form is not
in the process of being submitted

Change-Id: Ie5d1f632af056db64d4498b0590156f59306d9f6
Reviewed-on: http://review.couchbase.org/c/ns_server/+/159011
Well-Formed: Build Bot <[email protected]>
Reviewed-by: Matthew <[email protected]>
Tested-by: Pavel Blagodov <[email protected]>

Author: pavel-blagodov

priv/public/ui/app/mn_admin/mn_settings_auto_failover_controller.js

@@ -32,10 +32,15 @@ function mnSettingsAutoFailoverController($scope, $q, mnPromiseHelper, mnSetting
   var vm = this;
 
   mnSettingsClusterService.registerSubmitCallback(submit);
+  mnSettingsClusterService.registerInitChecker(() => (!!vm.autoFailoverSettings &&
+                                                      !!vm.reprovisionSettings));
 
   activate();
 
   function getAutoFailoverSettings() {
+    if (!vm.autoFailoverSettings) {
+      return;
+    }
     var settings = {
       enabled: vm.autoFailoverSettings.enabled,
       timeout: vm.autoFailoverSettings.timeout

priv/public/ui/app/mn_admin/mn_settings_cluster_controller.js

@@ -43,7 +43,7 @@ angular.module('mnSettingsCluster', [
   mnClusterConfigurationService,
 ]).controller('mnSettingsClusterController', mnSettingsClusterController);
 
-function mnSettingsClusterController($scope, $q, $uibModal, mnPoolDefault, mnMemoryQuotaService, mnSettingsClusterService, mnHelper, mnPromiseHelper, mnClusterConfigurationService, mnXDCRService) {
+function mnSettingsClusterController($scope, $q, $uibModal, mnPoolDefault, mnMemoryQuotaService, mnSettingsClusterService, mnHelper, mnPromiseHelper, mnClusterConfigurationService, mnXDCRService, $rootScope) {
   var vm = this;
   vm.saveVisualInternalSettings = saveVisualInternalSettings;
   vm.reloadState = mnHelper.reloadState;
@@ -69,7 +69,13 @@ function mnSettingsClusterController($scope, $q, $uibModal, mnPoolDefault, mnMem
       .catchErrorsFromSuccess("indexSettingsErrors");
   }, 500), true);
 
+  let submitted;
+
   function saveSettings() {
+    if (!isFormInitialized() || submitted) {
+      return;
+    }
+    submitted = true;
     var queries = [];
     var promise1 = mnPromiseHelper(vm, mnSettingsClusterService.postPoolsDefault(vm.memoryQuotaConfig, false, vm.clusterName))
         .catchErrors("memoryQuotaErrors")
@@ -170,7 +176,8 @@ function mnSettingsClusterController($scope, $q, $uibModal, mnPoolDefault, mnMem
       return cb();
     }));
 
-    var promiseAll = $q.all(queries);
+    var promiseAll = $q.all(queries)
+        .finally(() => (submitted = false));
     mnPromiseHelper(vm, promiseAll)
       .showGlobalSpinner()
       .reloadState()
@@ -221,8 +228,23 @@ function mnSettingsClusterController($scope, $q, $uibModal, mnPoolDefault, mnMem
     vm.initialCurlWhitelist = _.cloneDeep(queryCurl);
     vm.querySettings = querySettings;
   }
+  function isFormInitialized() {
+    let compat = mnPoolDefault.export.compat;
+    let cluster = $scope.rbac.cluster;
+    return (vm.clusterName != void 0) && (vm.initialMemoryQuota != void 0) &&
+      ((compat.atLeast55 && cluster.settings.read) ? (vm.querySettings != void 0) : true) &&
+      (cluster.xdcr.settings.read ? (vm.replicationSettings != void 0) : true) &&
+      (cluster.admin.memcached.read ? (vm.readerThreads != void 0) : true) &&
+      ((compat.atLeast66 && cluster.settings.read) ? (vm.settingsRebalance != void 0) : true) &&
+      ((compat.atLeast65 && mnPoolDefault.export.isEnterprise && cluster.settings.read) ?
+       (vm.retryRebalanceCfg != void 0) : true) &&
+      (cluster.settings.indexes.read ? (vm.indexSettings != void 0) : true) &&
+      mnSettingsClusterService.getInitChecker().every(v => v());
+
+  }
   function activate() {
     mnSettingsClusterService.clearSubmitCallbacks();
+    mnSettingsClusterService.clearInitChecker();
 
     mnPromiseHelper(vm, mnPoolDefault.get())
       .applyToScope(function (resp) {

priv/public/ui/app/mn_admin/mn_settings_cluster_service.js

@@ -23,9 +23,15 @@ function mnSettingsClusterServiceFactory($http, $q, IEC, mnPools, mnPoolDefault)
     postPoolsDefault: postPoolsDefault,
     getIndexSettings: getIndexSettings,
     postIndexSettings: postIndexSettings,
+
+    registerInitChecker: registerInitChecker,
+    clearInitChecker: clearInitChecker,
+    getInitChecker: getInitChecker,
+
     registerSubmitCallback: registerSubmitCallback,
     clearSubmitCallbacks: clearSubmitCallbacks,
     getSubmitCallbacks: getSubmitCallbacks,
+
     getSettingsRetryRebalance: getSettingsRetryRebalance,
     postSettingsRetryRebalance: postSettingsRetryRebalance,
     getSettingsRebalance: getSettingsRebalance,
@@ -37,6 +43,7 @@ function mnSettingsClusterServiceFactory($http, $q, IEC, mnPools, mnPoolDefault)
   };
 
   var childSubmitCallbacks = [];
+  var childInitChecker = [];
 
   return mnSettingsClusterService;
 
@@ -83,11 +90,23 @@ function mnSettingsClusterServiceFactory($http, $q, IEC, mnPools, mnPoolDefault)
     });
   }
 
+  function getInitChecker() {
+    return childInitChecker;
+  }
+
+  function clearInitChecker(cb) {
+    childInitChecker = [];
+  }
+
+  function registerInitChecker(cb) {
+    childInitChecker.push(cb);
+  }
+
   function getSubmitCallbacks() {
     return childSubmitCallbacks;
   }
 
-  function clearSubmitCallbacks (cb) {
+  function clearSubmitCallbacks(cb) {
     childSubmitCallbacks = [];
   }
 

priv/public/ui/app/mn_admin/mn_settings_notifications_controller.js

@@ -28,6 +28,7 @@ function mnSettingsNotificationsController(mnPromiseHelper, mnSettingsNotificati
   var vm = this;
 
   mnSettingsClusterService.registerSubmitCallback(submit);
+  mnSettingsClusterService.registerInitChecker(() => (vm.updates != void 0));
   vm.implementationVersion = pools.implementationVersion;
 
   activate();