MB-52258: refactor some config_profile calls

Makes the call to cluster_compat_mode internally inside the
config_profile.erl module instead of at all call sites where it was
previously used. Also made sure to route calls to search/2 through the
get/0 function so that it also checks cluster_compat_mode. Added a
warning comment to the 'is_serverless' call s/t people don't use it
unless it makes sense to do it.

Change-Id: I2ce9a543c6548090b7b0af8eb16c061a283c69ff
Reviewed-on: https://review.couchbase.org/c/ns_server/+/175773
Tested-by: Bryan McCoid <[email protected]>
Reviewed-by: Steve Watanabe <[email protected]>

Author: bryandmc

src/collections.erl

@@ -149,30 +149,15 @@ manifest_with_system_scope() ->
          {collections, Collections}]}]}].
 
 is_system_scope_enabled() ->
-    case cluster_compat_mode:is_cluster_elixir() of
-        false ->
-            false;
-        true ->
-            config_profile:get_bool(enable_system_scope)
-    end.
+    config_profile:get_bool(enable_system_scope).
 
 max_collections_per_bucket() ->
-    Default = get_max_supported(num_collections),
-    case cluster_compat_mode:is_cluster_elixir() of
-        false ->
-            Default;
-        true ->
-            config_profile:get_value(max_collection_per_bucket, Default)
-    end.
+    config_profile:get_value(max_collection_per_bucket,
+                             get_max_supported(num_collections)).
 
 max_scopes_per_bucket() ->
-    Default = get_max_supported(num_scopes),
-    case cluster_compat_mode:is_cluster_elixir() of
-        false ->
-            Default;
-        true ->
-            config_profile:get_value(max_scopes_per_bucket, Default)
-    end.
+    config_profile:get_value(max_scopes_per_bucket,
+                             get_max_supported(num_scopes)).
 
 default_kvs(Buckets, Nodes) ->
     lists:flatmap(

src/config_profile.erl

@@ -51,7 +51,12 @@ get() ->
 
 -spec(get(list()) -> list()).
 get(Default) ->
-    ns_config:search_node_with_default(?CONFIG_PROFILE, Default).
+    case cluster_compat_mode:is_cluster_elixir() of
+        false ->
+            Default;
+        true ->
+            ns_config:search_node_with_default(?CONFIG_PROFILE, Default)
+    end.
 
 -spec(get_value(term(), term()) -> term()).
 get_value(Key, Default) ->
@@ -69,6 +74,9 @@ search(Key) ->
 search(Key, Default) ->
     search_profile_key(Key, Default).
 
+%% @doc WARNING: Please only use this in certain situations. Instead you should
+%% be enabling features by individual flags inside the profile and not a blanket
+%% check for if we are using the "serverless" profile. You have been warned.
 -spec(is_serverless() -> boolean()).
 is_serverless() ->
     case name() of
@@ -84,7 +92,7 @@ search_profile_key(Key) ->
 
 -spec(search_profile_key(term(), term()) -> term()).
 search_profile_key(Key, Default) ->
-    ProfileData = ns_config:search_node_with_default(?CONFIG_PROFILE, []),
+    ProfileData = config_profile:get(),
     case lookup_profile_key(ProfileData, Key) of
         {value, Value} ->
             Value;
@@ -99,6 +107,4 @@ lookup_profile_key(ProfileData, Key) when is_list(ProfileData) ->
             {value, Value};
         _ ->
             false
-    end;
-lookup_profile_key(_, _) ->
-    false.
+    end.

src/ns_bucket.erl

@@ -816,12 +816,7 @@ get_default_num_vbuckets() ->
     end.
 
 allow_variable_num_vbuckets() ->
-    case cluster_compat_mode:is_cluster_elixir() of
-        false ->
-            false;
-        true ->
-            config_profile:get_bool(allow_variable_num_vbuckets)
-    end.
+    config_profile:get_bool(allow_variable_num_vbuckets).
 
 get_num_vbuckets(BucketConfig) ->
     proplists:get_value(num_vbuckets, BucketConfig).