MB-47149 Add version to checkPermissionsURI

The checkPermissionsURI field will now always include a version to
assist in determining when something related to the permissions has
changed.  Prior to this the version was only included for_ui calls.

  "checkPermissionsURI":
         "/pools/default/checkPermissions?v=ua21J2GkhnTQzt2mIa9uFB%2FUhH4%3D",

Change-Id: Id0622ee3b1d39f8d3c6ed549dbcff3af50d3f32b
Reviewed-on: https://review.couchbase.org/c/ns_server/+/165566
Well-Formed: Build Bot <[email protected]>
Tested-by: Steve Watanabe <[email protected]>
Reviewed-by: Abhijeeth Nuthan <[email protected]>

Author: stevewatanabe

src/menelaus_web_pools.erl

@@ -237,7 +237,7 @@ do_build_pool_info(Id, InfoLevel, Stability, LocalAddr) ->
          {clusterEncryptionLevel,
           misc:get_effective_cluster_encryption_level(Config)},
          {balanced, ns_cluster_membership:is_balanced()},
-         build_check_permissions_uri(InfoLevel, Id, Snapshot),
+         build_check_permissions_uri(Id, Snapshot),
          menelaus_web_node:build_memory_quota_info(Config),
          build_ui_params(InfoLevel, Snapshot),
          build_internal_params(InfoLevel),
@@ -275,15 +275,9 @@ build_ui_params(for_ui, Snapshot) ->
 build_ui_params(_, _) ->
     [].
 
-build_check_permissions_uri(InfoLevel, Id, Snapshot) ->
-    Params =
-        case InfoLevel of
-            for_ui ->
-                [{"v",
-                  menelaus_web_rbac:check_permissions_url_version(Snapshot)}];
-            _ ->
-                []
-        end,
+build_check_permissions_uri(Id, Snapshot) ->
+    Params = [{"v",
+               menelaus_web_rbac:check_permissions_url_version(Snapshot)}],
     {checkPermissionsURI, bin_concat_path(["pools", Id, "checkPermissions"],
                                           Params)}.