MB-47387 Increase magma bucket creation timeout

For a magma bucket there are 100s of files that must be opened and read.
Doing this is taking longer than the 2 minute timeout. So the default
for magma bucket creation is now 5 minutes.

This can be changed such as in this example to change to 700 seconds:

ns_config:set({node, node(),
              {timeout, {ns_memcached, magma_creation}}}, 700000).

Change-Id: I5b1438a4fcb984c50ed790ac3397a3cd55b90030
Reviewed-on: http://review.couchbase.org/c/ns_server/+/158683
Well-Formed: Build Bot <[email protected]>
Reviewed-by: Artem Stemkovski <[email protected]>
Tested-by: Steve Watanabe <[email protected]>

Author: stevewatanabe

src/mc_client_binary.erl

@@ -25,7 +25,7 @@
          cmd_quiet/3,
          cmd_vocal/3,
          respond/3,
-         create_bucket/4,
+         create_bucket/5,
          delete_bucket/3,
          delete_vbucket/2,
          delete_vbuckets/2,
@@ -205,11 +205,12 @@ auth(_Sock, _UnknownMech) ->
     {error, emech_unsupported}.
 
 % -------------------------------------------------
-create_bucket(Sock, BucketName, Engine, Config) ->
+create_bucket(Sock, BucketName, Engine, Config, Timeout) ->
     case cmd(?CMD_CREATE_BUCKET, Sock, undefined, undefined,
              {#mc_header{},
               #mc_entry{key = BucketName,
-                        data = list_to_binary([Engine, 0, Config])}}) of
+                        data = list_to_binary([Engine, 0, Config])}},
+             Timeout) of
         {ok, #mc_header{status=?SUCCESS}, _ME, _NCB} ->
             ok;
         Response -> process_error_response(Response)

src/memcached_bucket_config.erl

@@ -18,6 +18,7 @@
 -record(cfg, {type, name, config, snapshot, engine_config, params}).
 
 -export([get/1,
+         get_bucket_config/1,
          ensure/2,
          start_params/1,
          ensure_collections/2,
@@ -312,3 +313,6 @@ start_params(#cfg{config = BucketConfig,
 
     ExtraParams = [P || P <- [StaticConfigString, ExtraConfigString], P =/= ""],
     {Engine, string:join(DynamicParams ++ ExtraParams, ";")}.
+
+get_bucket_config(#cfg{config = BucketConfig}) ->
+    BucketConfig.

src/ns_memcached.erl

@@ -39,6 +39,7 @@
 -define(SLOW_CALL_THRESHOLD_MICROS, 500000).
 -define(GET_KEYS_TIMEOUT,       ?get_timeout(get_keys, 60000)).
 -define(GET_KEYS_OUTER_TIMEOUT, ?get_timeout(get_keys_outer, 70000)).
+-define(MAGMA_CREATION_TIMEOUT, ?get_timeout(magma_creation, 300000)).
 
 -define(RECBUF, ?get_param(recbuf, 64 * 1024)).
 -define(SNDBUF, ?get_param(sndbuf, 64 * 1024)).
@@ -1272,8 +1273,17 @@ do_ensure_bucket(Sock, Bucket, BConf, false) ->
             {Engine, ConfigString} =
                 memcached_bucket_config:start_params(BConf),
 
+            BucketConfig = memcached_bucket_config:get_bucket_config(BConf),
+            Timeout = case ns_bucket:kv_backend_type(BucketConfig) of
+                          magma ->
+                              ?MAGMA_CREATION_TIMEOUT;
+                          _ ->
+                              %% Use whatever the default value is
+                              undefined
+                      end,
+
             case mc_client_binary:create_bucket(Sock, Bucket, Engine,
-                                                ConfigString) of
+                                                ConfigString, Timeout) of
                 ok ->
                     ?log_info("Created bucket ~p with config string ~p",
                               [Bucket, ConfigString]),