Skip to content

Commit 8f6be46

Browse files
MB-47964: Fix backward compat for the following metrics
rest_requests, hibernated_waked, hibernated_requests Change-Id: I5e9fd6ec79be3222eed9e55aac0eca548ab19887 Reviewed-on: http://review.couchbase.org/c/ns_server/+/161023 Well-Formed: Build Bot <[email protected]> Well-Formed: Restriction Checker Tested-by: Timofey Barmin <[email protected]> Reviewed-by: Artem Stemkovski <[email protected]>
1 parent bcebe7f commit 8f6be46

File tree

1 file changed

+17
-9
lines changed

1 file changed

+17
-9
lines changed

src/stat_names_mappings.erl

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,17 @@ pre_70_stats_to_prom_query(StatSection, OrGroupSize, List, Opts) ->
6363
|| SubGroup <- misc:split(OrGroupSize, AstList)].
6464

6565
pre_70_stat_to_prom_query("@system", <<"rest_requests">>, Opts) ->
66-
{ok, promQL:rate({[{eq, <<"name">>, <<"sys_rest_requests">>}]}, Opts)};
66+
{ok, promQL:rate({[{eq, <<"name">>, <<"cm_rest_request_leaves_total">>}]},
67+
Opts)};
6768
pre_70_stat_to_prom_query("@system", <<"hibernated_waked">>, Opts) ->
68-
{ok, promQL:rate({[{eq, <<"name">>, <<"sys_hibernated_waked">>}]}, Opts)};
69+
{ok, promQL:rate({[{eq, <<"name">>, <<"cm_request_unhibernates_total">>}]},
70+
Opts)};
6971
pre_70_stat_to_prom_query("@system", <<"hibernated_requests">>, _Opts) ->
70-
{ok, promQL:named(<<"sys_hibernated_requests">>,
71-
{'-', [{ignoring, [<<"name">>]}],
72-
[{[{eq, <<"name">>, <<"sys_hibernated">>}]},
73-
{[{eq, <<"name">>, <<"sys_hibernated_waked">>}]}]})};
72+
{ok, promQL:named(
73+
<<"sys_hibernated_requests">>,
74+
{'-', [{ignoring, [<<"name">>]}],
75+
[{[{eq, <<"name">>, <<"cm_request_hibernates_total">>}]},
76+
{[{eq, <<"name">>, <<"cm_request_unhibernates_total">>}]}]})};
7477
pre_70_stat_to_prom_query("@system", Stat, _Opts) ->
7578
case is_system_stat(Stat) of
7679
true -> {ok, {[{eq, <<"name">>, <<"sys_", Stat/binary>>}]}};
@@ -582,6 +585,10 @@ prom_name_to_pre_70_name(Bucket, {JSONProps}) ->
582585
case proplists:get_value(<<"name">>, JSONProps) of
583586
<<"n1ql_", Name/binary>> ->
584587
{ok, <<"query_", Name/binary>>};
588+
<<"cm_rest_request_leaves_total">> ->
589+
{ok, <<"rest_requests">>};
590+
<<"cm_request_unhibernates_total">> ->
591+
{ok, <<"hibernated_waked">>};
585592
<<"sys_", Name/binary>> -> {ok, Name};
586593
<<"sysproc_", Name/binary>> ->
587594
Proc = proplists:get_value(<<"proc">>, JSONProps, <<>>),
@@ -967,9 +974,10 @@ pre_70_to_prom_query_test_() ->
967974
"sys_mem_actual_used|sys_mem_free|sys_mem_limit|"
968975
"sys_mem_total|sys_mem_used_sys|sys_odp_report_failed|"
969976
"sys_swap_total|sys_swap_used`} or "
970-
"irate({name=~`sys_hibernated_waked|sys_rest_requests`}[1m]) or "
971-
"label_replace({name=`sys_hibernated`} - ignoring(name) "
972-
"{name=`sys_hibernated_waked`},"
977+
"irate({name=~`cm_request_unhibernates_total|"
978+
"cm_rest_request_leaves_total`}[1m]) or "
979+
"label_replace({name=`cm_request_hibernates_total`} - ignoring(name) "
980+
"{name=`cm_request_unhibernates_total`},"
973981
"`name`,`sys_hibernated_requests`,``,``)"),
974982
Test("@system", [], ""),
975983
Test("@system-processes", all,

0 commit comments

Comments
 (0)