MB-47751: fix missed eslint errors

fix issues that were missed due to wrong .js files path

Change-Id: I07c3c3d364843c884c8268f12009d744a1ea7e23
Reviewed-on: http://review.couchbase.org/c/ns_server/+/160611
Tested-by: Pavel Blagodov <[email protected]>
Reviewed-by: Matthew <[email protected]>
Well-Formed: Build Bot <[email protected]>

Author: pavel-blagodov

priv/public/ui/app/ajs.upgraded.providers.js

@@ -89,7 +89,7 @@ const MnAlertsServiceProvider = {
   deps: ['$injector']
 };
 
-class MnServersService {};
+class MnServersService {}
 const MnServersServiceProvider = {
   provide: MnServersService,
   useFactory: function MnServersServiceFactory(i) {
@@ -98,7 +98,7 @@ const MnServersServiceProvider = {
   deps: ['$injector']
 };
 
-class MnStatisticsNewService {};
+class MnStatisticsNewService {}
 const MnStatisticsNewServiceProvider = {
   provide: MnStatisticsNewService,
   useFactory: function MnStatisticsNewServiceFactory(i) {

priv/public/ui/app/app.js

@@ -59,7 +59,7 @@ angular.module('app', [
   .constant("IEC", IEC)
   .run(appRun);
 
-function appRun($state, $urlRouter, $exceptionHandler, mnPools, $window, $rootScope, $location, $http, mnPrettyVersionFilter) {
+function appRun($state, $urlRouter, $exceptionHandler, mnPools, $window, $rootScope) {
 
   angular.element($window).on("storage", function (storage) {
     if (storage.key === "mnLogIn") {
@@ -81,11 +81,8 @@ function appRun($state, $urlRouter, $exceptionHandler, mnPools, $window, $rootSc
     originalOnerror && originalOnerror.apply($window, Array.prototype.slice.call(arguments));
   }
 
-  $http({method: "GET", url: "/versions"}).then(function (resp) {
-    var pools = resp.data;
-    var version = mnPrettyVersionFilter(pools.implementationVersion);
-    $rootScope.mnTitle = "Couchbase Server";
-  });
+
+  $rootScope.mnTitle = "Couchbase Server";
 
   $state.defaultErrorHandler(function (error) {
     error && $exceptionHandler(error);

priv/public/ui/app/app_config.js

@@ -77,18 +77,18 @@ function appConfig($httpProvider, $stateProvider, $urlRouterProvider, $transitio
 
     if (!original.commonBucket) {
       let params = Object.assign({}, original);
-      ;(["bucket", "scenarioBucket", "collectionsBucket", "indexesBucket"])
-          .forEach(bucket => {
-            if (params[bucket]) {
-              params.commonBucket = params[bucket];
-              if (bucket != "bucket") {
-                //do not remove 'bucket' parameter since this is
-                //popular pluggable UI param, so we just pass it
-                //along with commonBucket parameter
-                delete params[bucket];
-              }
+      (["bucket", "scenarioBucket", "collectionsBucket", "indexesBucket"])
+        .forEach(bucket => {
+          if (params[bucket]) {
+            params.commonBucket = params[bucket];
+            if (bucket != "bucket") {
+              //do not remove 'bucket' parameter since this is
+              //popular pluggable UI param, so we just pass it
+              //along with commonBucket parameter
+              delete params[bucket];
             }
-          });
+          }
+        });
 
       if (params.commonBucket) {
         return trans.router.stateService.target(trans.to().name, params);
@@ -147,7 +147,6 @@ function appConfig($httpProvider, $stateProvider, $urlRouterProvider, $transitio
     from: "app.admin.**",
     to: "app.admin.**"
   }, function (trans) {
-    var mnPools = trans.injector().get('mnPools');
     var $rootScope = trans.injector().get('$rootScope');
     var mnPendingQueryKeeper = trans.injector().get('mnPendingQueryKeeper');
     var $uibModalStack = trans.injector().get('$uibModalStack');
@@ -195,7 +194,7 @@ function appConfig($httpProvider, $stateProvider, $urlRouterProvider, $transitio
     var mnPermissions = trans.injector().get('mnPermissions');
     var $parse = trans.injector().get('$parse');
     return mnPermissions.check().then(function() {
-      if (!!$parse(trans.to().data.permissions)(mnPermissions.export)) {
+      if ($parse(trans.to().data.permissions)(mnPermissions.export)) {
         return true;
       } else {
         return trans.router.stateService.target('app.admin.overview.statistics');
@@ -210,7 +209,7 @@ function appConfig($httpProvider, $stateProvider, $urlRouterProvider, $transitio
     var mnPoolDefault = trans.injector().get('mnPoolDefault');
     var $parse = trans.injector().get('$parse');
     return mnPoolDefault.get().then(function() {
-      if (!!$parse(trans.to().data.compat)(mnPoolDefault.export.compat)) {
+      if ($parse(trans.to().data.compat)(mnPoolDefault.export.compat)) {
         return true;
       } else {
         return trans.router.stateService.target('app.admin.overview.statistics');

priv/public/ui/app/components/directives/mn_detail_stats_controller.js

@@ -8,6 +8,7 @@ be governed by the Apache License, Version 2.0, included in the file
 licenses/APL2.txt.
 */
 
+import angular from "/ui/web_modules/angular.js";
 import mnStatisticsNewService from "/ui/app/mn_admin/mn_statistics_service.js";
 import mnStatisticsDescriptionService from "/ui/app/mn_admin/mn_statistics_description_service.js";
 import mnStatisticsChart from "/ui/app/mn_admin/mn_statistics_chart_directive.js";

priv/public/ui/app/components/directives/mn_field_directive.js

@@ -36,7 +36,7 @@ function mnFieldDirective() {
 
   return mnFieldDirective;
 
-  function controller($scope) {
+  function controller() {
 
   }
 }

priv/public/ui/app/components/directives/mn_filter/mn_filter.js

@@ -16,7 +16,7 @@ angular
   .module("mnFilter", [])
   .directive("mnFilter", mnFilterDirective);
 
-function mnFilterDirective($window) {
+function mnFilterDirective() {
   var mnFilter = {
     restrict: "A",
     scope: {
@@ -34,7 +34,7 @@ function mnFilterDirective($window) {
 
   return mnFilter;
 
-  function mnFilterController($scope) {
+  function mnFilterController() {
     var vm = this;
 
     vm.togglePopup = togglePopup;

priv/public/ui/app/components/directives/mn_launchpad.js

@@ -27,7 +27,7 @@ function mnLaunchpadDirective($timeout) {
 
   return mnLaunchpad;
 
-  function link($scope, $element, $attrs) {
+  function link($scope, $element) {
     $scope.$watch('launchpadSource', function (launchpadSource) {
       if (!launchpadSource) {
         return;

priv/public/ui/app/components/directives/mn_memory_quota/mn_memory_quota.js

@@ -10,16 +10,15 @@ licenses/APL2.txt.
 
 import angular from "/ui/web_modules/angular.js";
 import mnFocus from "/ui/app/components/directives/mn_focus.js";
-import mnMemoryQuotaService from "/ui/app/components/directives/mn_memory_quota/mn_memory_quota_service.js";
 import mnServices from "/ui/app/components/directives/mn_services/mn_services.js";
 
 export default "mnMemoryQuota";
 
 angular
-  .module('mnMemoryQuota', [mnServices, mnFocus, mnMemoryQuotaService])
+  .module('mnMemoryQuota', [mnServices, mnFocus])
   .directive('mnMemoryQuota', mnMemoryQuotaDirective);
 
-function mnMemoryQuotaDirective($window, mnMemoryQuotaService) {
+function mnMemoryQuotaDirective() {
   var mnMemoryQuota = {
     restrict: 'A',
     scope: {

priv/public/ui/app/components/directives/mn_memory_quota/mn_memory_quota_service.js

@@ -72,7 +72,7 @@ function mnMemoryQuotaServiceFactory($http, $window, mnPoolDefault, mnHelper, IE
   }
   function isOnlyOneNodeWithService(nodes, services, service, isTakenIntoAccountPendingEject) {
     var nodesCount = 0;
-    var indexExists = _.each(nodes, function (node) {
+    _.each(nodes, function (node) {
       nodesCount += (_.indexOf(node.services, service) > -1 && !(isTakenIntoAccountPendingEject && node.pendingEject));
     });
     return nodesCount === 1 && services && (angular.isArray(services) ? (_.indexOf(services, service) > -1) : services[service]);

priv/public/ui/app/components/directives/mn_services/mn_services.js

@@ -17,7 +17,7 @@ angular
   .module('mnServices', [mnMemoryQuotaService])
   .directive('mnServices', mnServicesDirective);
 
-function mnServicesDirective(mnMemoryQuotaService) {
+function mnServicesDirective() {
   var mnServices = {
     restrict: 'A',
     scope: {